From owner-p4-projects@FreeBSD.ORG Wed Jul 16 12:31:16 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 03013106566B; Wed, 16 Jul 2008 12:31:16 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BADD41065685 for ; Wed, 16 Jul 2008 12:31:15 +0000 (UTC) (envelope-from weongyo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 049738FC1B for ; Wed, 16 Jul 2008 12:31:15 +0000 (UTC) (envelope-from weongyo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m6GCVEaX043230 for ; Wed, 16 Jul 2008 12:31:14 GMT (envelope-from weongyo@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m6GCVE4J043228 for perforce@freebsd.org; Wed, 16 Jul 2008 12:31:14 GMT (envelope-from weongyo@FreeBSD.org) Date: Wed, 16 Jul 2008 12:31:14 GMT Message-Id: <200807161231.m6GCVE4J043228@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to weongyo@FreeBSD.org using -f From: Weongyo Jeong To: Perforce Change Reviews Cc: Subject: PERFORCE change 145325 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2008 12:31:16 -0000 http://perforce.freebsd.org/chv.cgi?CH=145325 Change 145325 by weongyo@weongyo_ws on 2008/07/16 12:30:16 before we call a USB request (or transfer), make sure that there is a sleepable lock normally it'd be Giant for USB1 framework. Affected files ... .. //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#11 edit Differences ... ==== //depot/projects/ndisusb/sys/compat/ndis/subr_usbd.c#11 (text+ko) ==== @@ -584,7 +584,9 @@ USETW(req.wValue, vcreq->uvc_value); USETW(req.wLength, vcreq->uvc_trans_buflen); + mtx_lock(&Giant); status = usbd_do_request(uaa->device, &req, vcreq->uvc_trans_buf); + mtx_unlock(&Giant); return usbd_usb2urb(status); }