Date: Mon, 21 Oct 2013 08:47:04 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Alex Kozlov <ak@freebsd.org> Subject: Re: svn commit: r331046 - head/Mk/Scripts Message-ID: <20131021064704.GA29510@ithaqua.etoilebsd.net> In-Reply-To: <CAF6rxg=iZAkgtZtHDUq6Sb_2t2bcW23xhrdCNkQtU-KFvF_a7Q@mail.gmail.com> References: <201310201812.r9KICnwq080041@svn.freebsd.org> <CAF6rxg=iZAkgtZtHDUq6Sb_2t2bcW23xhrdCNkQtU-KFvF_a7Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 20, 2013 at 03:01:38PM -0400, Eitan Adler wrote: > On Sun, Oct 20, 2013 at 2:12 PM, Alex Kozlov <ak@freebsd.org> wrote: > > Author: ak > > Date: Sun Oct 20 18:12:49 2013 > > New Revision: 331046 > > URL: http://svnweb.freebsd.org/changeset/ports/331046 > > > > Log: > > - Add check for suid files and directories >=20 > Can you please add an in-port variable to disable this (NEEDS_SUID / > NEEDS_ROOT) or remove this check? >=20 > Warnings which may be ignored are not very useful. >=20 I do not think this is really a good way. First NEED_ROOT is a temporary kn= ob and should die as soon a possible as everything should be doable as a user. Second, SUID should remain rare enough so that people are not bothered by t= his warning all the time, but only a few time when they know it is useful, mean= ing they only have to ignore it when they know about. No port maintainer at all should be "discovering" that there are setuid fil= es in his packages so all of them should expect that warning. Alex: no need to change anything. regards, Bapt --wac7ysb48OaltWcw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlJkzegACgkQ8kTtMUmk6EwpnwCeM8Q6lcWO/v0rMz7PA6is7vXl 14sAoLQZOV3ElO92J0J3dNE5B65VtMqX =o+Rn -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131021064704.GA29510>