From owner-freebsd-ports  Thu Sep  7  9:36:43 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from radon.gryphonsoft.com (mcut-b-167.resnet.purdue.edu [128.211.209.167])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6557537B423; Thu,  7 Sep 2000 09:36:41 -0700 (PDT)
Received: by radon.gryphonsoft.com (Postfix, from userid 1000)
	id 350C21A56; Thu,  7 Sep 2000 11:34:37 -0500 (EST)
Date: Thu, 7 Sep 2000 11:34:37 -0500
From: Will Andrews <will@physics.purdue.edu>
To: Satoshi Asami <asami@FreeBSD.ORG>
Cc: ports@FreeBSD.ORG
Subject: Re: fetch-recursive/checksum-recursive
Message-ID: <20000907113437.Q23702@radon.gryphonsoft.com>
Reply-To: Will Andrews <will@physics.purdue.edu>
Mail-Followup-To: Will Andrews <will@physics.purdue.edu>,
	Satoshi Asami <asami@FreeBSD.ORG>, ports@FreeBSD.ORG
References: <200009060136.e861aBU17761@silvia.hip.berkeley.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200009060136.e861aBU17761@silvia.hip.berkeley.edu>; from asami@FreeBSD.ORG on Tue, Sep 05, 2000 at 06:36:11PM -0700
X-Operating-System: FreeBSD 4.1-STABLE i386
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Tue, Sep 05, 2000 at 06:36:11PM -0700, Satoshi Asami wrote:
> What do people say about the following?  It will implement the likes
> of fetch-recursive, as requested by PR ports/12548.

I apologize that I was unable to reply to your private email about this
sooner.  In any case, thanks for taking the time to make an acceptable
patch (to yourself, anyway, and that's not an easy job ;).

>  	for dir in $$(${ECHO} "${FETCH_DEPENDS} ${BUILD_DEPENDS} ${LIB_DEPENDS} ${RUN_DEPENDS}" | ${TR} '\040' '\012' | ${SED} -e 's/^[^:]*://' -e 's/:.*//') $$(${ECHO} ${DEPENDS} | ${TR} '\040' '\012' | ${SED} -e 's/:.*//'); do \

I've always wondered what those '\040' and '\012' escape codes refer to.
Does this `tr' command essentially perform the equivalent of chomp() in
Perl (my best guess)?

>  deinstall-depends:
> -	@for dir in $$(${CLEAN-DEPENDS-LIST}); do \
> -		(cd $$dir; ${MAKE} NOCLEANDEPENDS=yes deinstall); \
> +	@for dir in $$(${ALL-DEPENDS-LIST}); do \
> +		(cd $$dir; ${MAKE} deinstall); \

Won't this result in multiple deinstalls of a particular port (and thus
some failed deinstalls) ?

> +.if !target(fetch-recursive)
> +fetch-recursive:
> +	@${ECHO_MSG} "===> Fetching all distfiles for ${PKGNAME} and dependencies"
> +	@for dir in ${.CURDIR} $$(${ALL-DEPENDS-LIST}); do \
> +		(cd $$dir; ${MAKE} fetch); \
> +	done
> +.endif
> +
> +.if !target(fetch-recursive-list)
> +fetch-recursive-list:
> +	@for dir in ${.CURDIR} $$(${ALL-DEPENDS-LIST}); do \
> +		(cd $$dir; ${MAKE} fetch-list); \
> +	done
> +.endif
> +
> +.if !target(checksum-recursive)
> +checksum-recursive:
> +	@${ECHO_MSG} "===> Fetching and checking checksums for ${PKGNAME} and dependencies"
> +	@for dir in ${.CURDIR} $$(${ALL-DEPENDS-LIST}); do \
> +		(cd $$dir; ${MAKE} checksum); \
>  	done
>  .endif

Ok, this all looks good.  The question is: Does it work?  :P

-- 
Will Andrews <will@physics.purdue.edu> <will@FreeBSD.org>
GCS/E/S @d- s+:+ a--- C++ UB++++$ P+ L- E--- W+ N-- !o ?K w---
O- M+ V- PS+ PE++ Y+ PGP+>+++ t++ 5 X+ R+ tv+ b++ DI+++ D+ 
G++ e>++++ h! r- y?


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message