Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Dec 2015 11:20:11 +0100
From:      Christian Brueffer <brueffer@FreeBSD.org>
To:        Roman Divacky <rdivacky@freebsd.org>, John Baldwin <jhb@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r292236 - in head: contrib/mdocml lib lib/libc/sys lib/libsysdecode share/mk usr.bin/kdump usr.bin/truss
Message-ID:  <566FE95B.4010702@FreeBSD.org>
In-Reply-To: <20151215095604.GA28067@vlakno.cz>
References:  <201512150005.tBF057l2097434@repo.freebsd.org> <20151215095604.GA28067@vlakno.cz>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2015-12-15 10:56, Roman Divacky wrote:
> On Tue, Dec 15, 2015 at 12:05:07AM +0000, John Baldwin wrote:
>> Author: jhb
>> Date: Tue Dec 15 00:05:07 2015
>> New Revision: 292236
>> URL: https://svnweb.freebsd.org/changeset/base/292236
>>
>> Log:
>>   Start on a new library (libsysdecode) that provides routines for decoding
>>   system call information such as system call arguments.  Initially this
>>   will consist of pulling duplicated code out of truss and kdump though it
>>   may prove useful for other utilities in the future.
>>   
>>   This commit moves the shared utrace(2) record parser out of kdump into
>>   the library and updates kdump and truss to use it.  One difference from
>>   the previous version is that the library version treats unknown events
>>   that start with the "RTLD" signature as unknown events.  This simplifies
>>   the interface and allows the consumer to decide how to handle all
>>   non-recognized events.  Instead, this function only generates a string
>>   description for known malloc() and RTLD records.
>>   
>>   Reviewed by:	bdrewery
>>   Differential Revision:	https://reviews.freebsd.org/D4537
>>
>> Added:
>>   head/lib/libsysdecode/
>>   head/lib/libsysdecode/Makefile   (contents, props changed)
>>   head/lib/libsysdecode/sysdecode.3   (contents, props changed)
>>   head/lib/libsysdecode/sysdecode.h   (contents, props changed)
>>   head/lib/libsysdecode/sysdecode_utrace.3   (contents, props changed)
>>   head/lib/libsysdecode/utrace.c
>>      - copied, changed from r292235, head/usr.bin/kdump/utrace.c
>> Deleted:
>>   head/usr.bin/kdump/utrace.c
>> Modified:
>>   head/contrib/mdocml/lib.in
>>   head/lib/Makefile
>>   head/lib/libc/sys/utrace.2
>>   head/share/mk/bsd.libnames.mk
>>   head/share/mk/src.libnames.mk
>>   head/usr.bin/kdump/Makefile
>>   head/usr.bin/kdump/Makefile.depend
>>   head/usr.bin/kdump/kdump.c
>>   head/usr.bin/truss/Makefile
>>   head/usr.bin/truss/Makefile.depend.amd64
>>   head/usr.bin/truss/syscalls.c
>>
>> Modified: head/contrib/mdocml/lib.in
>> ==============================================================================
>> --- head/contrib/mdocml/lib.in	Mon Dec 14 23:25:31 2015	(r292235)
>> +++ head/contrib/mdocml/lib.in	Tue Dec 15 00:05:07 2015	(r292236)
>> @@ -110,6 +110,7 @@ LINE("libsdp",		"Bluetooth Service Disco
>>  LINE("libssp",		"Buffer Overflow Protection Library (libssp, \\-lssp)")
>>  LINE("libstdthreads",	"C11 Threads Library (libstdthreads, \\-lstdthreads)")
>>  LINE("libSystem",	"System Library (libSystem, \\-lSystem)")
>> +LINE("libsysdcode",	"System Argument Decoding Library (libsysdecode, \\-lsysdecode)")
> 
> Is this a typo?
> 

It is; fixed in r292257.

Good spotting!

Chris



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?566FE95B.4010702>