From owner-svn-src-all@FreeBSD.ORG Wed May 8 21:07:34 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id EA294F4E; Wed, 8 May 2013 21:07:34 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ie0-x230.google.com (mail-ie0-x230.google.com [IPv6:2607:f8b0:4001:c03::230]) by mx1.freebsd.org (Postfix) with ESMTP id A43A7D50; Wed, 8 May 2013 21:07:34 +0000 (UTC) Received: by mail-ie0-f176.google.com with SMTP id at1so4125670iec.21 for ; Wed, 08 May 2013 14:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=Br1AJTFNiNLZi/ZFYRnEn8UPEoRMV3QAJo9e4V+ee68=; b=uO/LxoaSk0wu71uoSWYkPnNLU3tXcBXNWqSJ5ZFHzTP9UNFOAvBAdnNzhHC2vn4VxK gvWpPUNo+0ksLX+THzVFyILNEaOX4RDsUzgJRbQvLKaVTWqVHQTl0eW7O7tQDJnUCjw/ fC+Eyw4vwXwQW+BhaOhJ0qBINZFQEkVwogAUguCpn5/nV4fL0IAr+kNQsbtzQ3RbYLm4 BsNMxxoHU2sJ4VywCSpd9HHK4omX8TGAx3HpXTkmtd02P6E20JzYcHwAUt42cCBMMZMI 0EDsJ21lB5l5ZG/Ww2TeNs98BxBOmPLno//bxn9FUMB3bD3ynLZAZRBFzcRsVch8yZEf 8gsQ== MIME-Version: 1.0 X-Received: by 10.43.158.3 with SMTP id ls3mr2694979icc.55.1368047254442; Wed, 08 May 2013 14:07:34 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.42.117.134 with HTTP; Wed, 8 May 2013 14:07:34 -0700 (PDT) In-Reply-To: <201305081653.33646.jhb@freebsd.org> References: <201305072249.r47MnvrO009846@svn.freebsd.org> <201305081201.16405.jhb@freebsd.org> <201305081653.33646.jhb@freebsd.org> Date: Wed, 8 May 2013 23:07:34 +0200 X-Google-Sender-Auth: 2Zq_x0_tUWODwdHAb8KdaHFkQ9w Message-ID: Subject: Re: svn commit: r250339 - head/sys/x86/acpica From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2013 21:07:35 -0000 On Wed, May 8, 2013 at 10:53 PM, John Baldwin wrote: > On Wednesday, May 08, 2013 2:21:12 pm Attilio Rao wrote: >> On Wed, May 8, 2013 at 6:01 PM, John Baldwin wrote: >> > On Tuesday, May 07, 2013 6:49:57 pm Attilio Rao wrote: >> >> Author: attilio >> >> Date: Tue May 7 22:49:56 2013 >> >> New Revision: 250339 >> >> URL: http://svnweb.freebsd.org/changeset/base/250339 >> >> >> >> Log: >> >> Add functions to do ACPI System Locality Information Table parsing >> >> and printing at boot. >> >> For reference on table informations and purposes please review ACPI specs. >> >> >> >> Sponsored by: EMC / Isilon storage division >> >> Obtained from: jeff >> >> Reviewed by: jhb (earlier version) >> > >> > Eh, I don't recall reviewing this. However, acpidump already dumps this >> > table, and we should dump tables via acpidump, not in dmesg. >> >> Now that I read better this patch is based upon a patch you submitted >> originally (see the private thread NUMA WIP). >> We already print some useful ACPI table information at boot really >> (APIC ACPI table case) and this is only printed out when having >> MAXMEMDOM > 1. Finally I have also sent you this patch and you didn't >> object. > > Humm, that was in an old thread, and I never responded to say "ok" to > this. > > However, the patch I posted in that thread is the patch to dump the SLIT > in acpidump and it was comitted back in r241198. That is the place to dump > these tables, not in dmesg. We do not dump the raw contents of any other > ACPI tables in dmesg, and have actively moved other tables out to userland > (e.g. $PIR is dumped via a userland tool only). > >> However if you really dislike it I can print under bootverbose maybe? > > No, it does not belong in dmesg at all. Code to use its contents and honor > it when setting the domain lists would be fine :), but printing it when you > can more easily get it via acpidump -t is just clutter. Reverted in r 250389. Attilio -- Peace can only be achieved by understanding - A. Einstein