From owner-svn-src-all@freebsd.org Wed Jan 10 17:01:43 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2CE49E67BD0 for ; Wed, 10 Jan 2018 17:01:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E00697E7EA for ; Wed, 10 Jan 2018 17:01:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x234.google.com with SMTP id f143so208932itb.0 for ; Wed, 10 Jan 2018 09:01:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Z14fbbqa3TKgxQR8UqCfTxtroV0hsH2kORlUZktUpiI=; b=K6bz6sYwT+2/rKUjUYtL8jBXv2xIKH7S71dYGjntfQ2OjHZG9eaamqVujiIVcZ/Zei +l71v21rMNx0qhxK2468T5tOOZw+HBqmTtb6Awq6OpjQaZMA5K5gahrtKZYDJ5NVXyG2 tW2pRG8DOk0WBwXr2eAtoiTuMLA90R8TQmCFjyR0kcQNjSPuUBUTnfT8fWwaUF17FOW9 jUbobDmfmVd6MssKIbdXU+0J16ANoB8dJ/OqmX/3WhC91rJtsrU3Bp9ETC9Fd0Y3SLyV MObympXuH24h8ucZIKh8EkuWL9M8SLpoOs0dhBChZqdIsCtQRfnKrtbwo2IzBkUi9JCP EVfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Z14fbbqa3TKgxQR8UqCfTxtroV0hsH2kORlUZktUpiI=; b=kt08ht4edIqMpf2rfIDdNemHcC7i6A7TFVsHCD835c+CTfFwsHDohWqQKyj9dcxsJd gawMjmaj5JfUZei22fU4RduNSc5S7mTXnUTyiXdbGknhzOp34UCgdrAsPdsQQ//VqVEk PZ+5FPffTq9aN+20R49gnrU0rhfi+njEPHZSRJIKXBFLq3varU5zlY+rAcAEmJh3dxoa Sb5nFy1hChTMdqS9Nzg90Dwoc8SSVTx1mUFWyPEPL7TfY9iH28t+J7ukPx+26JecbhWL Lj564tS2w8cuz2c7BsAuvwocpKxuGrgpnkOav6snWgRpwZ9A8uUC8p+9h7TD2DmLcSCu IvfA== X-Gm-Message-State: AKGB3mJ9YyyitQAsfI5CoLIhBE1CgkPyAeAmMpzK45rvZnL9a4pdHJNu izw+psM/dqcIpbSg1mrlYNFQct7gx0YYJtboQ9qOyg== X-Google-Smtp-Source: ACJfBovfhmrzyD1ijZf8vQ17Q37dMTkkVmP3w7EWj0uzHTtYhpp2V1J1xmv4zSgMilOfr8qg7LBMbPfMhHs4MDIM80s= X-Received: by 10.36.74.200 with SMTP id k191mr20637676itb.69.1515603702200; Wed, 10 Jan 2018 09:01:42 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.160.217 with HTTP; Wed, 10 Jan 2018 09:01:41 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20180110165821.GA69465@FreeBSD.org> References: <201801101459.w0AExJWM055025@repo.freebsd.org> <201801101631.w0AGVAEV032087@pdx.rh.CN85.dnsmgr.net> <20180110165821.GA69465@FreeBSD.org> From: Warner Losh Date: Wed, 10 Jan 2018 10:01:41 -0700 X-Google-Sender-Auth: hPMWm9T2XPeWbx6rHoMnrMaz5PA Message-ID: Subject: Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa To: Alexey Dokuchaev Cc: "Rodney W. Grimes" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 17:01:43 -0000 On Wed, Jan 10, 2018 at 9:58 AM, Alexey Dokuchaev wrote: > On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote: > > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote: > > > > New Revision: 327767 > > > > URL: https://svnweb.freebsd.org/changeset/base/327767 > > > > > > > > Log: > > > > Retire pmtimer driver. Move time fixing into apm driver. Move > > > > Iwasaki-san's copyright over. Remove FIXME code that couldn't > possibly > > > > work. Call tc_settime() with our estimate of the delta we've been > > > > alseep (the one we print) to adjust the time. Not sure what to do > > > > about callouts, so keep the small #ifdef in place there. > > > > > > > > Differential Revision: https://reviews.freebsd.org/D13823 > > > > > > RELNOTES: ? > > > Reason I ask is this effects custom kernel config file(s) > > > > Don't know. We don't normally document every kernel config file changes > > that's required. > > Well, `pmtimer' is a bit special. It is required in the kernel config in > order to preserve time counting during suspend (not sure about amd64, but > at least on i386, "device pmtimer" is required to be in kernel config for > timekeeping while sleeping). > It's only required for APM. ACPI it's a nop. And it didn't (until I believe that I fixed it) even adjust the time for APM. On APM it just prints how long the sleep was. Warner