From owner-cvs-src@FreeBSD.ORG  Sat Aug 23 15:29:37 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 091B2106567B;
	Sat, 23 Aug 2008 15:29:37 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id CD2A38FC1C;
	Sat, 23 Aug 2008 15:29:36 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7NFTaOc010726;
	Sat, 23 Aug 2008 15:29:36 GMT (envelope-from imp@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7NFTaiB010725;
	Sat, 23 Aug 2008 15:29:36 GMT (envelope-from imp@repoman.freebsd.org)
Message-Id: <200808231529.m7NFTaiB010725@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	imp@repoman.freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
Date: Sat, 23 Aug 2008 15:29:28 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/dev/mii mlphy.c tlphy.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Aug 2008 15:29:37 -0000

imp         2008-08-23 15:29:28 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/mii          mlphy.c tlphy.c 
  Log:
  SVN rev 182064 on 2008-08-23 15:29:28Z by imp
  
  It turns out that my analysis of the error handling here was wrong.
  When there's an error, we don't want to free the children, since it
  will be stack garbage.  While we did fail to dereference it by setting
  devs to 0, we didn't fail to call free.  We never failed to fail, it
  was the easiest thing to do.
  
  Revision  Changes    Path
  1.24      +7 -7      src/sys/dev/mii/mlphy.c
  1.24      +2 -3      src/sys/dev/mii/tlphy.c