From owner-cvs-src@FreeBSD.ORG Thu Aug 26 13:10:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F9B416A4CE; Thu, 26 Aug 2004 13:10:32 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BACE43D5E; Thu, 26 Aug 2004 13:10:32 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 5F71AAC995; Thu, 26 Aug 2004 15:10:30 +0200 (CEST) Date: Thu, 26 Aug 2004 15:10:30 +0200 From: Pawel Jakub Dawidek To: Poul-Henning Kamp Message-ID: <20040826131030.GO30151@darkness.comp.waw.pl> References: <200408261242.i7QCgl7m012027@repoman.freebsd.org> <58622.1093524972@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhNoKa8EeSU2TVlt" Content-Disposition: inline In-Reply-To: <58622.1093524972@critter.freebsd.dk> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label g_label.c src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c src/sys/geom/stripe g_stripe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2004 13:10:32 -0000 --AhNoKa8EeSU2TVlt Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 26, 2004 at 02:56:12PM +0200, Poul-Henning Kamp wrote: +> In message <200408261242.i7QCgl7m012027@repoman.freebsd.org>, Pawel Jaku= b Dawid +> ek writes: +>=20 +> > Log: +> > Skip providers with not defined sector size. +>=20 +> This is wrong. A provider with a non-zero access count should always +> have a sector size. The sectorsize can not be trusted if the access +> counts are zero. Yes, I know that it should be done this way, but I'm not going to fix atapi-cd.c, scsi_da.c and scsi_cd.c and who knows what else. Those classes set error to 0 even when provider has not sectorsize and mediasize defined. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --AhNoKa8EeSU2TVlt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBLeFGForvXbEpPzQRAoFXAJ4kkZACzU72UkoXl2ZTdLHj5JReAQCggfvQ gJEMDEGwE43rfzdjTy1CAOM= =l9RB -----END PGP SIGNATURE----- --AhNoKa8EeSU2TVlt--