From owner-freebsd-hackers@freebsd.org Tue Oct 6 04:59:18 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 355FD9BAF95 for ; Tue, 6 Oct 2015 04:59:18 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 16C6EDD7 for ; Tue, 6 Oct 2015 04:59:18 +0000 (UTC) (envelope-from rpaulo@me.com) Received: by mailman.ysv.freebsd.org (Postfix) id 13F8F9BAF94; Tue, 6 Oct 2015 04:59:18 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 138A59BAF92 for ; Tue, 6 Oct 2015 04:59:18 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp004.me.com (mr11p00im-asmtp004.me.com [17.110.69.135]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E3D0CDD5; Tue, 6 Oct 2015 04:59:17 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from akita.hsd1.ca.comcast.net (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp004.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NVS00EP68IJOE10@mr11p00im-asmtp004.me.com>; Tue, 06 Oct 2015 04:59:11 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-06_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=7.38298311375729e-15 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1510060085 Message-id: <1444107547.6210.35.camel@me.com> Subject: Re: boostrap target From: Rui Paulo To: Ian Lepore Cc: hackers@freebsd.org, NGie Cooper Date: Mon, 05 Oct 2015 21:59:07 -0700 In-reply-to: <1444096802.66572.115.camel@freebsd.org> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444094009.66572.105.camel@freebsd.org> <1444096463.6210.31.camel@me.com> <1444096802.66572.115.camel@freebsd.org> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.16.5-1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 04:59:18 -0000 On Mon, 2015-10-05 at 20:00 -0600, Ian Lepore wrote: > I decided the "beforedepend: bootstrap" attempt at a fix was wrong, > because it led to always using the precompiled/processed versions of > the > generated files on every pass (boostrap tools, world, crossbuilding), > and I think that wasn't the intention. I discovered (by accident, > actually) that there was no need to run the bootstap target at all as > long as m4 got built before lex during the bootstrap-tools stage, so > that's the fix I applied, and it was sufficient to build current and > stable-10 on a stable-8 build host. Well, I thought that was what jkim added in 2013. Is your BOOTSTRAPPING variable set correctly? diff --git a/Makefile.inc1 b/Makefile.inc1 index 1e58f47..f0649ef 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -1206,6 +1206,10 @@ _sed= usr.bin/sed _lex= usr.bin/lex .endif +.if ${BOOTSTRAPPING} < 1000002 +_m4= usr.bin/m4 +.endif + .if ${BOOTSTRAPPING} < 1000013 _yacc= lib/liby \ usr.bin/yacc @@ -1283,6 +1287,7 @@ bootstrap-tools: usr.bin/rpcgen \ ${_sed} \ ${_yacc} \ + ${_m4} \ ${_lex} \ lib/libmd \ usr.bin/xinstall \ > > I suppose at this point the bootstrap target, and all the pre > -generated > files it copies, could be deleted. Unless they're serving some other > purpose I'm not aware of, like maybe some folks have a need to run > that > target manually. Looking again, all the GENFILES are generated by the bootstrap target based on the rule init$f -> $f. However, as you say it probably should be deleted because there's no difference between init$f and $f. -- Rui Paulo