From owner-cvs-sys  Sun Dec 21 08:31:29 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id IAA10976
          for cvs-sys-outgoing; Sun, 21 Dec 1997 08:31:29 -0800 (PST)
          (envelope-from owner-cvs-sys)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id IAA10961;
          Sun, 21 Dec 1997 08:31:12 -0800 (PST)
          (envelope-from bde@zeta.org.au)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.6.9) id DAA17627; Mon, 22 Dec 1997 03:26:20 +1100
Date: Mon, 22 Dec 1997 03:26:20 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199712211626.DAA17627@godzilla.zeta.org.au>
To: bde@zeta.org.au, max@wide.ad.jp
Subject: Re: cvs commit: src/sys/net if_slvar.h
Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG,
        eivind@FreeBSD.ORG
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>     > It was.  This is slattach.c's fault for including a private
>     > header.  It wasn't even used.
>
>I found the same problem with startslip.c.

It also has the same disorder and even more unused includes than slattach.

Bruce

diff -c2 startslip.c~ startslip.c
*** startslip.c~	Sat Jun 21 15:56:11 1997
--- startslip.c	Mon Dec 22 03:13:49 1997
***************
*** 45,56 ****
  
  #include <sys/types.h>
- #include <sys/ioctl.h>
- #include <sys/socket.h>
  #include <sys/time.h>
  
  #include <errno.h>
  #include <fcntl.h>
  #include <paths.h>
- #include <netdb.h>
  #include <signal.h>
  #include <stdio.h>
--- 45,55 ----
  
  #include <sys/types.h>
  #include <sys/time.h>
  
+ #include <err.h>
  #include <errno.h>
  #include <fcntl.h>
+ #include <libutil.h>
  #include <paths.h>
  #include <signal.h>
  #include <stdio.h>
***************
*** 61,71 ****
  #include <time.h>
  #include <unistd.h>
- #include <libutil.h>
- #include <err.h>
  
- #include <netinet/in.h>
- #include <net/if.h>
- #include <net/if_var.h>
- #include <net/if_slvar.h>
  #include <net/slip.h>
  
--- 60,64 ----