From owner-freebsd-bugs@FreeBSD.ORG Thu Jan 19 08:20:08 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0804216A41F for ; Thu, 19 Jan 2006 08:20:08 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 81D5E43D4C for ; Thu, 19 Jan 2006 08:20:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0J8K7qk070702 for ; Thu, 19 Jan 2006 08:20:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0J8K7lL070701; Thu, 19 Jan 2006 08:20:07 GMT (envelope-from gnats) Date: Thu, 19 Jan 2006 08:20:07 GMT Message-Id: <200601190820.k0J8K7lL070701@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Cc: Subject: Re: bin/91973 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2006 08:20:08 -0000 The following reply was made to PR bin/91973; it has been noted by GNATS. From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) To: freebsd-gnats-submit@freebsd.org Cc: Subject: Re: bin/91973 Date: Thu, 19 Jan 2006 09:19:47 +0100 The patch in the PR is incorrect. A MODE failure should not be ignored, as it may result in the wrong data being transferred; and it is bad form to use warn() or warnx() in a library. However, as a compromise, it may be acceptable to ignore a MODE failure if and only if the mode we tried to set was "s". DES --=20 Dag-Erling Sm=F8rgrav - des@des.no