From owner-svn-ports-all@FreeBSD.ORG  Tue Nov 27 22:07:00 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id BF4814DA;
 Tue, 27 Nov 2012 22:07:00 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id AF5238FC19;
 Tue, 27 Nov 2012 22:06:59 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id je9so5251039bkc.13
 for <multiple recipients>; Tue, 27 Nov 2012 14:06:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type;
 bh=CVGNHvBwfxKBpjmXYUlJGIezXTgNaYJ4k1XPt288IjM=;
 b=XGCwCi63RWjy2sxwQCVohyC0DADzHgsOuP5aZnLN0oUw4AGZ1qjVgViwohbjaMgz+R
 Fp843FajYBN8C6yVjNP3mdkojxDL++t8x41kmiBJChpdRds4Z9YlWyigwbuL//Pia7vB
 ASecgG1Z6ArZKe/STnw7XnldsUBD8LtxaTc5vv50QNG8Kk580dwiXgdtg9r61rJOmXqu
 tfHR7x7vBlsJ+s2Kv4n9jR3man/Vwk1d70VWwZIv4eMmnDaRU3pSi+SqoKU6LxvQCbyW
 bmOr+PYdH6leLfkQUoBgQw0LCVAmjRMLwp24lX9znya0wqAmOFmkZNnZTStwMo0qs6GE
 46kw==
Received: by 10.204.4.131 with SMTP id 3mr4936432bkr.25.1354054018303; Tue, 27
 Nov 2012 14:06:58 -0800 (PST)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.204.167.71 with HTTP; Tue, 27 Nov 2012 14:06:28 -0800 (PST)
In-Reply-To: <201211272141.qARLfTwt065159@svn.freebsd.org>
References: <201211272141.qARLfTwt065159@svn.freebsd.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Tue, 27 Nov 2012 22:06:28 +0000
X-Google-Sender-Auth: MK23nDHe5wcADqDIMqKRY1hF1qY
Message-ID: <CADLo838iKfc=VpAriPFP3hKGKmnktXka4ioX5Jwc9O+ywU++Yg@mail.gmail.com>
Subject: Re: svn commit: r307863 - in head/security/fwknop: . files
To: Raphael Kubo da Costa <rakuco@freebsd.org>, sean.greven@gmail.com
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2012 22:07:01 -0000

On 27 November 2012 21:41, Raphael Kubo da Costa <rakuco@freebsd.org> wrote:
> XXX Ports RC script present
> Author: rakuco
> Date: Tue Nov 27 21:41:29 2012
> New Revision: 307863
> URL: http://svnweb.freebsd.org/changeset/ports/307863
>
> Log:
>   Update to 2.0.3.
>
>   This new version includes a migration from Perl to C and support for
>   ipfw and pf.
>
>   While here, trim the Makefile headers.
>
>   PR:           ports/171951  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=171951
>   Submitted by: Sean Greven <sean.greven@gmail.com> (maintainer)
>   Feature safe: yes
>
> Added:
>   head/security/fwknop/files/fwknopd.in   (contents, props changed)

[snip]

> Added: head/security/fwknop/files/fwknopd.in
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/security/fwknop/files/fwknopd.in       Tue Nov 27 21:41:29 2012        (r307863)
> @@ -0,0 +1,41 @@
> +#!/bin/sh
> +#
> +# $FreeBSD$
> +#
> +# PROVIDE: fwknopd
> +# REQUIRE: LOGIN
> +
> +#
> +# Add the following lines to /etc/rc.conf to enable fwknopd:
> +#
> +# fwknopd_enable="YES"
> +#
> +# See fwknopd(8) for flags
> +#
> +
> +. /etc/rc.subr
> +
> +name=fwknopd
> +rcvar=fwknopd_enable
> +
> +command=%%PREFIX%%/sbin/fwknopd
> +required_files=%%PREFIX%%/etc/fwknop/access.conf
> +
> +start_precmd=start_precmd
> +stop_postcmd=stop_postcmd
> +
> +extra_commands="reload"
> +
> +start_precmd()
> +{
> +}
> +
> +stop_postcmd()
> +{
> +}
> +
> +# read settings, set default values
> +load_rc_config $name
> +: ${fwknopd_enable="NO"}
> +
> +run_rc_command "$1"

Various style fixes to the rc script are at [1] (as well as not
causing an ungracious kill at shutdown :), please take a look.

Chris

[1] http://www.bayofrum.net/~crees/patches/fwknop-rc-script.diff