Date: Tue, 28 Feb 2017 15:32:49 -0600 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Ravi Pokala <rpokala@mac.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r314373 - in head: . etc/defaults etc/rc.d lib/libc/regex share/man/man4/man4.i386 share/man/man5 sys/amd64/conf sys/boot/forth sys/compat/svr4 sys/conf sys/dev/streams sys/i386/conf sy... Message-ID: <CAJ5_RoDsBYBaDLGiLwNakDVpJRczpAxwyBRLsEiwwT9g_tfNVg@mail.gmail.com> In-Reply-To: <20170228213044.GK1044@FreeBSD.org> References: <201702280514.v1S5EhPq060885@repo.freebsd.org> <1969312.3TTRqhLH9r@ralph.baldwin.cx> <A783EF14-114B-4547-9737-3BB13FCE5DC4@panasas.com> <20170228193605.GJ1044@FreeBSD.org> <CAJ5_RoDzO_1OkyJ=aZAHUDBXib882%2Ba0fB0GvdQqnjUxkL6Arg@mail.gmail.com> <20170228213044.GK1044@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 28, 2017 at 3:30 PM, Gleb Smirnoff <glebius@freebsd.org> wrote: > On Tue, Feb 28, 2017 at 01:39:12PM -0600, Benjamin Kaduk wrote: > B> > I don't think this deserves UPDATING entry, since it doesn't require > B> > any action from a person who updates from sources. > B> > > B> > I don't think this requires __FreeBSD_version bump, since the latter > B> > is used to assist compilation of open source application that use > B> > changed API. The change removed support to run binaries. > B> > > B> > B> That is not the only use of __FreeBSD_version, which is (at least) > exposed > B> to the ports collection and can cause conditional changes in what are > B> shipped by ports. > B> Which is not to say that any current ports ship affected binaries, of > B> course, but just to point out that the scope of the symbol is broader > than > B> stated. > > How can I check the __FreeBSD_version in a port Makefile? My understanding > is that there is no standard way for such thing. Of course I can parse > /usr/include/sys/param.h... > > My understanding is that the constant is for sources only: > > https://www.freebsd.org/doc/en/books/porters-handbook/ > porting-versions.html > > Look for OSVERSION in /usr/ports/Mk/bsd.port.mk -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoDsBYBaDLGiLwNakDVpJRczpAxwyBRLsEiwwT9g_tfNVg>