From owner-cvs-src@FreeBSD.ORG  Sun Apr  3 13:41:06 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5978D16A4CE; Sun,  3 Apr 2005 13:41:06 +0000 (GMT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E110243D5A; Sun,  3 Apr 2005 13:41:03 +0000 (GMT)
	(envelope-from scottl@freebsd.org)
Received: from pooker.samsco.org (localhost [127.0.0.1])
	by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j33DiFMr035742;
	Sun, 3 Apr 2005 07:44:15 -0600 (MDT)
	(envelope-from scottl@freebsd.org)
Received: from localhost (scottl@localhost)j33DiFaI035739;
	Sun, 3 Apr 2005 07:44:15 -0600 (MDT)
	(envelope-from scottl@freebsd.org)
X-Authentication-Warning: pooker.samsco.org: scottl owned process doing -bs
Date: Sun, 3 Apr 2005 07:44:15 -0600 (MDT)
From: Scott Long <scottl@freebsd.org>
Sender: scottl@pooker.samsco.org
To: Jeff Roberson <jeff@freebsd.org>
In-Reply-To: <200504031029.j33ATtAX021544@repoman.freebsd.org>
Message-ID: <20050403074335.A35686@pooker.samsco.org>
References: <200504031029.j33ATtAX021544@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Spam-Status: No, score=-2.2 required=3.8 tests=ALL_TRUSTED,SUBJ_HAS_SPACES 
	autolearn=failed version=3.0.2
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_extern.h ffs_softdep.c        
 ffs_vfsops.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Apr 2005 13:41:06 -0000

On Sun, 3 Apr 2005, Jeff Roberson wrote:
> jeff        2005-04-03 10:29:55 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/ufs/ffs          ffs_extern.h ffs_softdep.c ffs_vfsops.c
>  Log:
>   - Move the contents of softdep_disk_prewrite into ffs_geom_strategy to fix
>     two bugs.
>   - ffs_disk_prewrite was pulling the vp from the buf and checking for
>     COPYONWRITE, when really it wanted the vp from the bufobj that we're
>     writing to, which is the devvp.  This lead to us skipping the copy on
>     write to all file data, which significantly broke snapshots for the
>     last few months.
>   - When the SOFTUPDATES option was not included in the kernel config we
>     would also skip the copy on write check, which would effectively disable
>     snapshots.

I thought that snapshots required softupdates?

Scott