From owner-svn-src-head@freebsd.org Thu Nov 14 14:41:41 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 50BCC1A9A36; Thu, 14 Nov 2019 14:41:41 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-xc35.google.com (mail-yw1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47DPLr3QZ1z41YW; Thu, 14 Nov 2019 14:41:40 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-yw1-xc35.google.com with SMTP id m196so1915691ywd.5; Thu, 14 Nov 2019 06:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qj9UJmkByLNe2czT448zxiMUb+FVtF4Icd4cGzpemEo=; b=cvDVoVrmR3tSYasWcJshSSf/FblTcIuppQIdI9ZsLRp/xbtib2enAYBYQssbJ89oaO wa/rQegU74QdfcGpAMps+Y061XNg64U41ulyI65S6BXOqNhYtPT9O0pGuFQOAVx2JB+5 A8qk6z1rLmgqhrx8eiHuWL8fn86AzK60hDtH9mFzs4nUzekpNlyRmL0vOcl8eVvftfJo Va4V5BiYdCVQ893/iF4CG7XBEf3hC8U4y76KUkUV+B52RIpJWcNBCpf+u2Ry67/O+YKv EUO/VOKT3FQ52PjfC4ot0RivaK940y+l6oa9tV+Dp+kDHL6Fu/GDGIlFuISMvb5hzSh6 Dg9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=qj9UJmkByLNe2czT448zxiMUb+FVtF4Icd4cGzpemEo=; b=HCD0GAPY9K7XfD4H8HImZX3IoA3kenGfXCyH2nD30EO5thFt1GvP24/nglcU2wcUTC SnIZpuNce2nV9n0icitwY0EzA6HOdsuOEgkL629n39bIshB8ebb4UwGOVlDTboQimY0c fw89oy62aTcTgNkxu9spA2BUTkzurLOTbtOgakZ9yniJkDVPsb4m3QH74Vh1clEVuWKx 1U2daUElymQwPHAUAwHA6VnX1SOqZu2jsknq6eVlu1G7b9MjKv4h/aKIO1CqSH2xZ3p4 hzkeH788Kp7HkmpeNPSqQBMVRWmcWtxTcN5aXsCMal+Yj/ISKOulegMxTez/nhn9MysI xAsQ== X-Gm-Message-State: APjAAAV1mSQlvRcYuMFhGJMZi58Jtj7fnHBTO3ZGA0NoUbJYZTDPOCOe v6+ZI1h7AKpYTM++sYFgOiONw04i X-Google-Smtp-Source: APXvYqwlRWOIC4CSfkgFKFX7AMluHvcorZSosSlJw7+cmIK8Lt1JiVp3d+ASQRaVd7+IdLfMiJ4TDA== X-Received: by 2002:a81:5885:: with SMTP id m127mr5913804ywb.484.1573742498371; Thu, 14 Nov 2019 06:41:38 -0800 (PST) Received: from mavoffice.ixsystems.com ([12.189.233.129]) by smtp.gmail.com with ESMTPSA id i128sm1672380ywc.31.2019.11.14.06.41.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2019 06:41:37 -0800 (PST) Sender: Alexander Motin Subject: Re: svn commit: r354703 - head/sys/dev/ioat To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201911140439.xAE4dngZ032224@repo.freebsd.org> <20191114101149.GA2707@kib.kiev.ua> From: Alexander Motin Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAG0IUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPokBVwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raS5AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczM AAoJEIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLq A6xe6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHu uC5vgPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15Gc sS9YcQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9 TevwGsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCg lz65AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6ZAXgD tmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8FlvmI/c 40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt3ytU 8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZR1Ed EIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm59R8A EQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczMAAoJ EIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLqA6xe 6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHuuC5v gPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15GcsS9Y cQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9Tevw Gsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCglz4= Message-ID: <475757c6-3707-540b-0316-cbef278043c2@FreeBSD.org> Date: Thu, 14 Nov 2019 09:41:36 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191114101149.GA2707@kib.kiev.ua> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 47DPLr3QZ1z41YW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=cvDVoVrm; dmarc=none; spf=pass (mx1.freebsd.org: domain of mavbsd@gmail.com designates 2607:f8b0:4864:20::c35 as permitted sender) smtp.mailfrom=mavbsd@gmail.com X-Spamd-Result: default: False [-4.81 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[5.3.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.61)[ip: (-8.68), ipnet: 2607:f8b0::/32(-2.32), asn: 15169(-1.99), country: US(-0.05)]; FORGED_SENDER(0.30)[mav@FreeBSD.org,mavbsd@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[mav@FreeBSD.org,mavbsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2019 14:41:41 -0000 On 14.11.2019 05:11, Konstantin Belousov wrote: > On Thu, Nov 14, 2019 at 04:39:49AM +0000, Alexander Motin wrote: >> Author: mav >> Date: Thu Nov 14 04:39:48 2019 >> New Revision: 354703 >> URL: https://svnweb.freebsd.org/changeset/base/354703 >> >> Log: >> Pass more reasonable WAIT flags to bus_dma(9) calls. >> >> MFC after: 2 weeks >> >> Modified: >> head/sys/dev/ioat/ioat.c >> >> Modified: head/sys/dev/ioat/ioat.c >> ============================================================================== >> --- head/sys/dev/ioat/ioat.c Thu Nov 14 04:34:58 2019 (r354702) >> +++ head/sys/dev/ioat/ioat.c Thu Nov 14 04:39:48 2019 (r354703) >> @@ -555,13 +555,14 @@ ioat3_attach(device_t device) >> &ioat->comp_update_tag); >> >> error = bus_dmamem_alloc(ioat->comp_update_tag, >> - (void **)&ioat->comp_update, BUS_DMA_ZERO, &ioat->comp_update_map); >> + (void **)&ioat->comp_update, BUS_DMA_ZERO | BUS_DMA_WAITOK, >> + &ioat->comp_update_map); > For waitok, you need to provide locking function in the tag. I'm sorry, but why? It is alloc(), not load(). For load() it makes sense since it calls back, but this is just a form of malloc(), isn't it? I've looked through the both x86 implementations and found nothing suspicious. -- Alexander Motin