Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Sep 2015 12:19:37 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r288308 - head/sys/dev/nxge/xgehal
Message-ID:  <201509271219.t8RCJb1m063403@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bz
Date: Sun Sep 27 12:19:36 2015
New Revision: 288308
URL: https://svnweb.freebsd.org/changeset/base/288308

Log:
  Fix what looks like a consistent copy&paste error.
  Don't make an integer to a boolean and then compare to a value which
  needs an integer comparison.
  
  Spotted by:	reading kernel compile time log
  MFC after:	2 weeks

Modified:
  head/sys/dev/nxge/xgehal/xgehal-fifo.c
  head/sys/dev/nxge/xgehal/xgehal-ring.c

Modified: head/sys/dev/nxge/xgehal/xgehal-fifo.c
==============================================================================
--- head/sys/dev/nxge/xgehal/xgehal-fifo.c	Sun Sep 27 12:17:03 2015	(r288307)
+++ head/sys/dev/nxge/xgehal/xgehal-fifo.c	Sun Sep 27 12:19:36 2015	(r288308)
@@ -464,7 +464,7 @@ __hal_fifo_hw_initialize(xge_hal_device_
 
 	    if (!hldev->config.fifo.queue[i].configured ||
 	        !hldev->config.fifo.queue[i].intr_vector ||
-	        !hldev->config.intr_mode != XGE_HAL_INTR_MODE_MSIX)
+	        hldev->config.intr_mode != XGE_HAL_INTR_MODE_MSIX)
 	        continue;
 
 	    /* find channel */

Modified: head/sys/dev/nxge/xgehal/xgehal-ring.c
==============================================================================
--- head/sys/dev/nxge/xgehal/xgehal-ring.c	Sun Sep 27 12:17:03 2015	(r288307)
+++ head/sys/dev/nxge/xgehal/xgehal-ring.c	Sun Sep 27 12:19:36 2015	(r288308)
@@ -609,7 +609,7 @@ __hal_ring_hw_initialize(xge_hal_device_
 
 	    if (!hldev->config.ring.queue[i].configured ||
 	        !hldev->config.ring.queue[i].intr_vector ||
-	        !hldev->config.intr_mode != XGE_HAL_INTR_MODE_MSIX)
+	        hldev->config.intr_mode != XGE_HAL_INTR_MODE_MSIX)
 	        continue;
 
 	    /* find channel */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201509271219.t8RCJb1m063403>