Date: Tue, 5 Dec 2017 13:06:40 -0800 From: Conrad Meyer <cem@freebsd.org> To: Cy Schubert <Cy.Schubert@komquats.com> Cc: Eitan Adler <eadler@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee Message-ID: <CAG6CVpX-EAPqaGLSjneCaku-yDPjgNj2ZfmZEawu-2_-gypWiA@mail.gmail.com> In-Reply-To: <201712052016.vB5KGc9T038423@slippy.cwsent.com> References: <eadler@freebsd.org> <CAF6rxgmydTftejsX1d8ePHLTRuyS3f0PAEVL7nwgU-HbdKW%2BSw@mail.gmail.com> <201712052016.vB5KGc9T038423@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 5, 2017 at 12:16 PM, Cy Schubert <Cy.Schubert@komquats.com> wro= te: > In message <CAF6rxgmydTftejsX1d8ePHLTRuyS3f0PAEVL7nwgU-HbdKW+Sw@mail.gmai= l.c > om> > , Eitan Adler writes: >> I'm not near my commit box right now so someone will have to revert >> it. What's funny is that I ran a complete 'make buildworld >> buildkernel' last night with this patch. >> >> Will respond to the rest of the thread later > > No problem. r326575 addresses the issue. Not fully =E2=80=94 it doesn't address that the code is functionally broken= or that the change touched things it didn't need to. I think a revert is still called for, when you can reach a machine with commit access. Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpX-EAPqaGLSjneCaku-yDPjgNj2ZfmZEawu-2_-gypWiA>