Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 01 Sep 2010 08:06:24 +0400
From:      Anonymous <swell.k@gmail.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/150173: [patch] lang/lua: don't override optimization with `-O2'
Message-ID:  <86d3sym7jz.fsf@gmail.com>
Resent-Message-ID: <201009010420.o814K1Sc037234@freefall.freebsd.org>

Next in thread | Raw E-Mail | Index | Archive | Help

>Number:         150173
>Category:       ports
>Synopsis:       [patch] lang/lua: don't override optimization with `-O2'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 01 04:20:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
While here allow overriding AR/RANLIB from environment or make.conf.
>How-To-Repeat:
$ make WITH_DEBUG= DEBUG_FLAGS='-O0 -ggdb3'
...
===>  Building for lua-5.1.4_1
cd src && make freebsd
make all MYCFLAGS="-DLUA_USE_LINUX" MYLIBS="-Wl,-E -lreadline"
cc -pipe -fPIC -O0 -ggdb3 -O2 -Wall -DLUA_USE_LINUX -c lapi.c
cc -pipe -fPIC -O0 -ggdb3 -O2 -Wall -DLUA_USE_LINUX -c lcode.c
...
>Fix:
--- a.diff begins here ---
Index: lang/lua/Makefile
===================================================================
RCS file: /a/.cvsup/ports/lang/lua/Makefile,v
retrieving revision 1.38
diff -u -p -r1.38 Makefile
--- lang/lua/Makefile	16 Aug 2010 12:29:21 -0000	1.38
+++ lang/lua/Makefile	1 Sep 2010 04:03:52 -0000
@@ -45,8 +45,8 @@ LUA_TEST=	README bisect.lua cf.lua echo.
 post-patch:
 	@${REINPLACE_CMD} -Ee \
 		'/^INSTALL_.*=/s/INSTALL_TOP/prefix/ ; \
-		 s|^(CC=).*|\1 ${CC}| ; \
-		 s|^(CFLAGS=)|\1 ${CFLAGS}| ; \
+		 s|^(CC\|AR\|RANLIB)=|\1?=| ; \
+		 /^CFLAGS=/ { s/=/+=/; s/-O2//; } ; \
 		 s|/usr/local|${PREFIX}|' \
 		 ${WRKSRC}/Makefile ${WRKSRC}/src/Makefile
 	@${REINPLACE_CMD} -i '' -Ee \
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?86d3sym7jz.fsf>