Date: Sun, 29 May 2016 14:21:29 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Cy Schubert <Cy.Schubert@komquats.com>, Cy Schubert <Cy.Schubert@cschubert.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org Subject: Re: svn commit: r300961 - vendor/one-true-awk/dist Message-ID: <1b8c118d-0743-ba8f-5796-65b165bc8efd@FreeBSD.org> In-Reply-To: <201605291906.u4TJ67AT082836@slippy.cwsent.com> References: <201605291906.u4TJ67AT082836@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/29/16 14:06, Cy Schubert wrote: > In message <201605291817.u4TIHnN7040344@slippy.cwsent.com>, Cy Schubert > writes: >> In message <574B2EAC.3010908@FreeBSD.org>, Pedro Giffuni writes: >>> >>> >>> >>> On 29/05/2016 12:37, Cy Schubert wrote: >>>> In message <201605291618.u4TGItNJ024583@repo.freebsd.org>, "Pedro F. >>>> Giffuni" w >>>> rites: >>>>> Author: pfg >>>>> Date: Sun May 29 16:18:55 2016 >>>>> New Revision: 300961 >>>>> URL: https://svnweb.freebsd.org/changeset/base/300961 >>>>> >>>>> Log: >>>>> one-true-awk: replace 0 with NULL for pointers >>>>> >>>>> Also remove a redundant semicolon. >>>>> Submitted upstream already. >>>>> >>>>> Modified: >>>>> vendor/one-true-awk/dist/b.c >>>>> vendor/one-true-awk/dist/lex.c >>>>> vendor/one-true-awk/dist/maketab.c >>>>> vendor/one-true-awk/dist/parse.c >>>>> vendor/one-true-awk/dist/run.c >>>>> vendor/one-true-awk/dist/tran.c >>>>> >>>> Was this commit and r300962 obtained from the upline or vendor or were >>>> these commits local to FreeBSD only? >>>> >>>> >>> There is no public awk public repository AFAICT, but bwk acknowledged >>> the submission. >>> >>> The change to openresolv was merged to the public repository. >> >> As they've acknowledged the submissions, can you please tag the new >> versions of awk and openresolve with the correct upstream version numbers, >> please? > > Additionally, if there are no new version numbers, what reason is there for > polluting the vendor branch with local patches to it? Is not the vendor > branch for virgin code retrieved (or received) from the vendor (or upline)? > > Heck! Can't you simply trust the committer knows what he is doing? http://roy.marples.name/projects/openresolv/info/12cb1c1fb10df107 For nawk there is not public repository but bwk's acknowlegement said: "Thanks -- that's something that I should have done long long ago." So I think both changes are pretty much vendor code now. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1b8c118d-0743-ba8f-5796-65b165bc8efd>