Date: Thu, 3 Mar 2011 14:32:36 -0500 From: John Baldwin <jhb@freebsd.org> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219181 - head/release Message-ID: <201103031432.36336.jhb@freebsd.org> In-Reply-To: <4D6FCE64.3010302@freebsd.org> References: <201103021606.p22G6vou020460@svn.freebsd.org> <201103031209.43857.jhb@freebsd.org> <4D6FCE64.3010302@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, March 03, 2011 12:22:44 pm Nathan Whitehorn wrote: > On 03/03/11 11:09, John Baldwin wrote: > > On Wednesday, March 02, 2011 11:06:57 am Nathan Whitehorn wrote: > >> Author: nwhitehorn > >> Date: Wed Mar 2 16:06:57 2011 > >> New Revision: 219181 > >> URL: http://svn.freebsd.org/changeset/base/219181 > >> > >> Log: > >> Add additional release makefile for bsdinstall-based media, along with > >> support files. This does not change the default behavior of anything. > >> > >> To make bsdinstall-based media, pre-build world and GENERIC, then run > >> the release target in Makefile.bsdinstall. > > Are you planning on keeping the current 'make release' behavior of building a > > full chroot and doing a clean build in the chroot to build a release? That > > is, is 'Makefile.bsdinstall' just a temporary shortcut for building test > > releases or is that the final replacement for 'release/Makefile'? > > It was intended (modulo memstick building, docs, and some miscellaneous > cleanup) to be the final replacement for release/Makefile. In my > experience, the automatic fetching, clean build, and chroot was a major > impediment to easily making installation media for users to test > patches. I figured that if people (e.g. re@) really want a totally clean > tree, checking one out by hand and building from there didn't seem like > an enormous obstacle. > > If you think it's a really important feature, I'm happy to add it back, > however. I think it is a very important feature to ensure release builds are not polluted by local changes in /etc/src.conf, etc. I think it would be good to support both models perhaps, but for our official release builds I think we need the clean environment. I certainly use 'make release' now for my own custom FooBSD builds to get a clean environment. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103031432.36336.jhb>