From owner-freebsd-amd64@FreeBSD.ORG Wed Feb 16 23:20:08 2011 Return-Path: Delivered-To: freebsd-amd64@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A8CCE1065673 for ; Wed, 16 Feb 2011 23:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 672588FC12 for ; Wed, 16 Feb 2011 23:20:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p1GNK8c5061436 for ; Wed, 16 Feb 2011 23:20:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p1GNK8JS061435; Wed, 16 Feb 2011 23:20:08 GMT (envelope-from gnats) Resent-Date: Wed, 16 Feb 2011 23:20:08 GMT Resent-Message-Id: <201102162320.p1GNK8JS061435@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-amd64@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrew Boyer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E638106564A for ; Wed, 16 Feb 2011 23:16:04 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 4F5C58FC0C for ; Wed, 16 Feb 2011 23:16:04 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p1GNG4u0081054 for ; Wed, 16 Feb 2011 23:16:04 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p1GNG44V081053; Wed, 16 Feb 2011 23:16:04 GMT (envelope-from nobody) Message-Id: <201102162316.p1GNG44V081053@red.freebsd.org> Date: Wed, 16 Feb 2011 23:16:04 GMT From: Andrew Boyer To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: amd64/154831: [patch] arp sysctl setting log_arp_permanent_modify has no effect X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2011 23:20:08 -0000 >Number: 154831 >Category: amd64 >Synopsis: [patch] arp sysctl setting log_arp_permanent_modify has no effect >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-amd64 >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 16 23:20:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Andrew Boyer >Release: stable/8 >Organization: Avere Systems >Environment: N/A >Description: SVN 153513 added a sysctl, net.link.ether.inet.log_arp_permanent_modify, which does not do anything since SVN 186119. It is simple to re-add. >How-To-Repeat: (Develop a networking problem like I've got...) - Turn off logging with 'sysctl net.link.ether.inet.log_arp_permanent_modify=0' - Observe that the log messages still appear >Fix: Patch attached with submission follows: Index: sys/netinet/if_ether.c =================================================================== --- sys/netinet/if_ether.c (revision 218760) +++ sys/netinet/if_ether.c (working copy) @@ -693,11 +693,13 @@ bcmp(ar_sha(ah), &la->ll_addr, ifp->if_addrlen)) { if (la->la_flags & LLE_STATIC) { LLE_WUNLOCK(la); - log(LOG_ERR, - "arp: %*D attempts to modify permanent " - "entry for %s on %s\n", - ifp->if_addrlen, (u_char *)ar_sha(ah), ":", - inet_ntoa(isaddr), ifp->if_xname); + if (log_arp_permanent_modify) { + log(LOG_ERR, + "arp: %*D attempts to modify permanent " + "entry for %s on %s\n", + ifp->if_addrlen, (u_char *)ar_sha(ah), ":", + inet_ntoa(isaddr), ifp->if_xname); + } goto reply; } if (log_arp_movements) { >Release-Note: >Audit-Trail: >Unformatted: