Date: Mon, 20 Feb 2006 18:39:28 -0800 From: Pascal Hofstee <caelian@gmail.com> To: gnome@freebsd.org Subject: Re: Eog Crash while opening jpeg-images with EXIF data Message-ID: <1140489568.847.8.camel@synergy.odyssey.homeunix.org> In-Reply-To: <1140487656.847.6.camel@synergy.odyssey.homeunix.org> References: <1140487656.847.6.camel@synergy.odyssey.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2006-02-20 at 18:07 -0800, Pascal Hofstee wrote: > i am noticing a consistent eog crash when opening jpeg images with EXIF > data (using MC-gnome, eog-2.13.91) on FreeBSD/amd64 7.0-CURRENT > > The line that causes the crash is libeog/eog-metadata-reader.c:231 > > memcpy ((void*) ((int)(priv->exif_chunk) + priv->bytes_read), > (void*)&buf[i], priv->size); > > I am about 99% sure the (int) typecast on priv->exit_chunk is truncating > the 64-bit pointer into 32-bits causing the application to segfault as a > result. I am not 100% on how to properly fix this. > > If any of you could have a look at this, that would be appreciated. Ok .. i had another closer look and noticed line 231 wasn't the only occurance of the 64-bit pointer truncation. I filed a bugzilla report on it (and added a patch to the bugzilla-report). http://bugzilla.gnome.org/show_bug.cgi?id=331971 This patch fixes the eog crashes on my system and should probably be reviewed/committed to MC-gnome. -- Pascal Hofstee
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1140489568.847.8.camel>