From owner-freebsd-gnome@FreeBSD.ORG Tue Feb 21 02:39:31 2006 Return-Path: X-Original-To: gnome@freebsd.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF1B416A420 for ; Tue, 21 Feb 2006 02:39:31 +0000 (GMT) (envelope-from caelian@gmail.com) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id 606A243D46 for ; Tue, 21 Feb 2006 02:39:31 +0000 (GMT) (envelope-from caelian@gmail.com) Received: by zproxy.gmail.com with SMTP id l8so1124955nzf for ; Mon, 20 Feb 2006 18:39:30 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:subject:from:to:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=oNejbG+j72yGG7T0enUfEY7A8mZ6npap5iGhunQiWjY5rc4jR0BQvThf/8JOTBuo4wSIYMpDewplNRVR/SyhyUjhv4/yAPbU4+AFCIZNoBUOs65+oiIs8mufHSW8NNqSPieaKMadXQEErlpa7g4YZ7YDOrkF+bLMuLmTxz33n9A= Received: by 10.37.14.18 with SMTP id r18mr6314800nzi; Mon, 20 Feb 2006 18:39:30 -0800 (PST) Received: from synergy.odyssey.homeunix.org ( [68.190.230.198]) by mx.gmail.com with ESMTP id r1sm4153749nzd.2006.02.20.18.39.29; Mon, 20 Feb 2006 18:39:30 -0800 (PST) From: Pascal Hofstee To: gnome@freebsd.org In-Reply-To: <1140487656.847.6.camel@synergy.odyssey.homeunix.org> References: <1140487656.847.6.camel@synergy.odyssey.homeunix.org> Content-Type: text/plain Date: Mon, 20 Feb 2006 18:39:28 -0800 Message-Id: <1140489568.847.8.camel@synergy.odyssey.homeunix.org> Mime-Version: 1.0 X-Mailer: Evolution 2.5.91 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: Subject: Re: Eog Crash while opening jpeg-images with EXIF data X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2006 02:39:32 -0000 On Mon, 2006-02-20 at 18:07 -0800, Pascal Hofstee wrote: > i am noticing a consistent eog crash when opening jpeg images with EXIF > data (using MC-gnome, eog-2.13.91) on FreeBSD/amd64 7.0-CURRENT > > The line that causes the crash is libeog/eog-metadata-reader.c:231 > > memcpy ((void*) ((int)(priv->exif_chunk) + priv->bytes_read), > (void*)&buf[i], priv->size); > > I am about 99% sure the (int) typecast on priv->exit_chunk is truncating > the 64-bit pointer into 32-bits causing the application to segfault as a > result. I am not 100% on how to properly fix this. > > If any of you could have a look at this, that would be appreciated. Ok .. i had another closer look and noticed line 231 wasn't the only occurance of the 64-bit pointer truncation. I filed a bugzilla report on it (and added a patch to the bugzilla-report). http://bugzilla.gnome.org/show_bug.cgi?id=331971 This patch fixes the eog crashes on my system and should probably be reviewed/committed to MC-gnome. -- Pascal Hofstee