From owner-svn-ports-head@FreeBSD.ORG Tue Sep 17 08:25:48 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B3999673; Tue, 17 Sep 2013 08:25:48 +0000 (UTC) (envelope-from kwm@rainbow-runner.nl) Received: from fep14.mx.upcmail.net (fep14.mx.upcmail.net [62.179.121.34]) by mx1.freebsd.org (Postfix) with ESMTP id 701CC244F; Tue, 17 Sep 2013 08:25:46 +0000 (UTC) Received: from edge01.upcmail.net ([192.168.13.236]) by viefep14-int.chello.at (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20130917082539.NCOV19378.viefep14-int.chello.at@edge01.upcmail.net>; Tue, 17 Sep 2013 10:25:39 +0200 Received: from [127.0.0.1] ([178.84.134.112]) by edge01.upcmail.net with edge id S8Re1m02C2Rg3Ey018RecU; Tue, 17 Sep 2013 10:25:39 +0200 X-SourceIP: 178.84.134.112 Message-ID: <52381201.8000209@rainbow-runner.nl> Date: Tue, 17 Sep 2013 10:25:37 +0200 From: Koop Mast User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Rusmir Dusko Subject: Re: svn commit: r327440 - in head/irc/hexchat: . files References: <20130917075135.GA38467@nemysis4now> In-Reply-To: <20130917075135.GA38467@nemysis4now> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 130916-1, 16-09-2013), Outbound message X-Antivirus-Status: Clean Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2013 08:25:48 -0000 On 17-9-2013 9:51, Rusmir Dusko wrote: >> On 16-9-2013 22:55, Rusmir Dusko wrote: >>> .if ! ${PORT_OPTIONS:MLIBSEXY} && ! ${PORT_OPTIONS:MGTKSPELL} && ! ${PORT_OPTIONS:MSTATIC} >>> CONFIGURE_ARGS+=--enable-spell=none >>> .endif >>> >>> +.if ${PORT_OPTIONS:MLIBSEXY} || ${PORT_OPTIONS:MGTKSPELL} || ${PORT_OPTIONS:MSTATIC} >>> +RUN_DEPENDS+=aspell:${PORTSDIR}/textproc/en-aspell >>> +.endif >>> + >>> .if ${PORT_OPTIONS:MSTATIC} >>> CONFIGURE_ARGS+=--enable-spell=static >>> .endif >> Shouldn't this be textproc/aspell ? The aspell binary is in that port >> and en-aspell only has EN dictionaries etc. > For test I have deleted all aspell Ports > > pkg info | grep aspell > > nothing > > /usr/ports/textproc/aspell/ ; make reinstall > > pkg info | grep aspell > aspell-0.60.6.1_2 Spelling checker with better suggestion logic than ispell > > pkg delete -f aspell-0.60.6.1_2 > > Also is needed to install textproc/en-aspell which install textproc/aspell > > /usr/ports/textproc/en-aspell ; make reinstall > > pkg info | grep aspell > aspell-0.60.6.1_2 Spelling checker with better suggestion logic than ispell > en-aspell-7.1.0_1 Aspell English dictionaries Fair enough if you want to install a dictionairy, I'm of the opinion that the uses needs to have the choice which dictionaries he wants to install. But my point is that the RUN_DEPEND line is wrong. The aspell binary is in the aspell port not en-aspell. If you want to depend on en-aspell you need to either check for a file from the en-aspell plist RUN_DEPENDS+=${LOCALBASE}/share/aspell/english.alias:${PORTSDIR}/textproc/en-aspell or check for the package RUN_DEPENDS+=en-aspell>=0:${PORTSDIR}/textproc/en-aspell -Koop