From owner-svn-src-all@freebsd.org Wed Jan 30 00:34:41 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9907114ADE5B for ; Wed, 30 Jan 2019 00:34:41 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 33A3572466; Wed, 30 Jan 2019 00:34:41 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x829.google.com with SMTP id t33so24455924qtt.4; Tue, 29 Jan 2019 16:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BTnlGLKnck5JWyWf2o0O4vVmMrSyGJ3NqCYMkuAgObE=; b=PoQ/TBiCn9FJXgcP79w5jGaQGwcDU6LHTgcGBzWgTNuRA1EJI+STl5kIzWN/5n9ESG RGqaAFdswFc1L7vYJxsVU2ZArm9s3foLlrfhqoTsNFQgJ/TteBd+bagtUDybEBd4cFkH fV0WymZdmXmBPCw8XyK8xuI8nUcHRzFqdm1+WJ9n2hcNuX2iOdz3q8xa6zFRrQ89Ijwn lNaB4ZhyAEHYRcqGrg9Qp7gQhrm6oJnBE+ocD5LJRmdKqB3QWOhu8efuK7ZikImv88e5 kkatGTqCagbf6LLorKKpuSsOxMRP8Km5DAYWbbzOs2sJyg1HOv5M39yP/B5YkBZ3bwAO 98KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=BTnlGLKnck5JWyWf2o0O4vVmMrSyGJ3NqCYMkuAgObE=; b=J4l2waFFgaF3OkKDRwz5cKhxx41y3g4q6+576BxX1CiEGZUNutdAubEjCoQ8OZjBfb /ev4ESQt6wT9On++jLgJXMjGHBafWbXv7RNqrjUFc27a3P6+Gv1a+avWOoq4R5syf3UE O2WcOYSDjdjX8jkli67GnO2enqx12SFBPr1+MMBDuPlxMEDbZ1zWt4sqrvEmmjfQCe1l A6nOQe5j/q8P6G6mP0ktdaxgpHTnaYrx68SIiMyhfGJa83ObItOoHAXQeq4/kzRwYznr dfGMMMPK/6QpLVgdx5j3rnpfATKnPbhph1tlY/mifrVJmTC1esJaOtOAIHfUvAV6+NT9 AupA== X-Gm-Message-State: AJcUukdJoeXps1XKC4v4ee9AUSYIF2YnCzQ+1RQu2zCNFuIP1YZ1Gq7j YB9ThMV18/wTulpZLWdKnjAJVtsaeZI= X-Google-Smtp-Source: ALg8bN4YkTBDgj4NfvHWvcHtg8ohPcz/Pr5ge8i3Kqw2u3O7Qs797yOmIHXqH5xqtjwM7Kpp1xH4dA== X-Received: by 2002:ac8:38e2:: with SMTP id g31mr27667878qtc.55.1548808480330; Tue, 29 Jan 2019 16:34:40 -0800 (PST) Received: from spy ([206.121.37.170]) by smtp.gmail.com with ESMTPSA id i73sm64731189qke.80.2019.01.29.16.34.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Jan 2019 16:34:39 -0800 (PST) Sender: Mark Johnston Date: Tue, 29 Jan 2019 19:34:32 -0500 From: Mark Johnston To: Marko Zec Cc: src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r343527 - in stable/12/sys/riscv: include riscv Message-ID: <20190130003432.GA2617@spy> References: <201901281614.x0SGErMq078921@repo.freebsd.org> <20190129192627.51acc721@x23> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129192627.51acc721@x23> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 33A3572466 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.978,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 00:34:41 -0000 On Tue, Jan 29, 2019 at 07:26:27PM +0100, Marko Zec wrote: > On Mon, 28 Jan 2019 16:14:53 +0000 > Mark Johnston wrote: > > > Author: markj > > Date: Mon Jan 28 16:14:53 2019 > > New Revision: 343527 > > URL: https://svnweb.freebsd.org/changeset/base/343527 > > > > Log: > > MFC r343274, r343275: > > Optimize RISC-V copyin(9)/copyout(9) routines. > > Was this subjected to any benchmarks? I'd bet that placing I only did some ad-hoc testing under QEMU with a few copyout()-intensive programs (a few procstat(1) invocations). In general I saw a roughly 5% decrease in runtimes. I don't yet have any hardware to test on, and I don't believe Mitchell (the submitter of the patch) does either. > addi a2, a2, -XLEN_BYTES > > before > > sd a4, 0(a1) > > instead of being scheduled after (the same goes for the byte copy loop) > would make the loops run faster on most in-order RV cores out there... That makes sense. I doubt it would make a difference under QEMU though.