Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 30 Jul 2005 00:16:31 -0400
From:      Anish Mistry <amistry@am-productions.biz>
To:        Kris Kennaway <kris@FreeBSD.org>, Ian Dowse <iedowse@maths.tcd.ie>
Cc:        freebsd-bugs@FreeBSD.org
Subject:   Re: conf/73799: Move the last stuff out of usbd.conf
Message-ID:  <200507300016.38993.amistry@am-productions.biz>
In-Reply-To: <200507300132.j6U1WZ9u003703@freefall.freebsd.org>
References:  <200507300132.j6U1WZ9u003703@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart4659468.NxX8AMHzNs
Content-Type: multipart/mixed;
  boundary="Boundary-01=_f8v6CEcs2lZvAQ+"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_f8v6CEcs2lZvAQ+
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 29 July 2005 09:32 pm, Kris Kennaway wrote:
> Synopsis: Move the last stuff out of usbd.conf
>
> State-Changed-From-To: feedback->closed
> State-Changed-By: kris
> State-Changed-When: Sat Jul 30 01:32:28 GMT 2005
> State-Changed-Why:
> Feedback timeout
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D73799
Patch attached.  It applies to 5-STABLE and 7.0-CURRENT.  It makes usb=20
tell devd about the "release" field.
I tested it with my Handspring Visor and Kensington Mouse and the=20
release value was honored.  We should be able to kill off usbd and=20
transfer everything since devd now know about release.

=2D-=20
Anish Mistry
amistry@am-productions.biz
AM Productions http://am-productions.biz/

--Boundary-01=_f8v6CEcs2lZvAQ+
Content-Type: text/x-diff; charset="iso-8859-1"; name="usb-release-devd.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="usb-release-devd.patch"

--- uhub.c.orig	Fri Jul 29 23:34:28 2005
+++ uhub.c	Fri Jul 29 23:46:09 2005
@@ -691,19 +691,18 @@
 	if (dev->ifacenums == NULL) {
 		snprintf(buf, buflen, "vendor=0x%04x product=0x%04x "
 		    "devclass=0x%02x devsubclass=0x%02x "
-		    "sernum=\"%s\"",
+		    "release=0x%04x sernum=\"%s\"",
 		    UGETW(dev->ddesc.idVendor), UGETW(dev->ddesc.idProduct),
-		    dev->ddesc.bDeviceClass, dev->ddesc.bDeviceSubClass,
-		    serial);
+		    dev->ddesc.bDeviceClass, dev->ddesc.bDeviceSubClass, UGETW(dev->ddesc.bcdDevice), serial);
 	} else {
 		iface = &dev->ifaces[dev->ifacenums[i]];
 		snprintf(buf, buflen, "vendor=0x%04x product=0x%04x "
 		    "devclass=0x%02x devsubclass=0x%02x "
-		    "sernum=\"%s\" "
+		    "release=0x%04x sernum=\"%s\" "
 		    "intclass=0x%02x intsubclass=0x%02x",
 		    UGETW(dev->ddesc.idVendor), UGETW(dev->ddesc.idProduct),
 		    dev->ddesc.bDeviceClass, dev->ddesc.bDeviceSubClass,
-		    serial,
+		    UGETW(dev->ddesc.bcdDevice), serial,
 		    iface->idesc->bInterfaceClass,
 		    iface->idesc->bInterfaceSubClass);
 	}

--Boundary-01=_f8v6CEcs2lZvAQ+--

--nextPart4659468.NxX8AMHzNs
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)

iD8DBQBC6v8mxqA5ziudZT0RApw8AJ9ZgoDWWss+YaTyF7IN8Y65UJIf6ACgib92
AJmgdHsNBWq4+CArNOTONjE=
=/3uR
-----END PGP SIGNATURE-----

--nextPart4659468.NxX8AMHzNs--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507300016.38993.amistry>