Date: Tue, 16 Nov 2004 12:48:50 -0700 From: "Jie Gao" <gaoj@cpsc.ucalgary.ca> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/74011: math/sdpara has a broken Makefile when WITH_OPTIMIZED_FLAGS is defined Message-ID: <200411161948.iAGJmpQT012684@imgw1.cpsc.ucalgary.ca> Resent-Message-ID: <200411161950.iAGJo61Y057949@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 74011 >Category: ports >Synopsis: math/sdpara has a broken Makefile when WITH_OPTIMIZED_FLAGS is defined >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 16 19:50:06 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Jie Gao >Release: FreeBSD 5.3-STABLE i386 >Organization: >Environment: System: FreeBSD aibsd 5.3-STABLE FreeBSD 5.3-STABLE #1: Tue Nov 9 12:08:20 MST 2004 gaoj@aibsd:/usr/obj/usr/src/sys/AIBSD i386 >Description: math/sdpara has a broken Makefile when WITH_OPTIMIZED_FLAGS is defined. The problem is in a if branch. So when WITH_OPTIMIZED_FLAGS is not defined, a user cannot observe the error. But once WITH_OPTIMIZED_FLAGS is defined, the error is exposed. >How-To-Repeat: cd /usr/ports/math/sdpara make -DWITH_OPTIMIZED_FLAGS You will get error message about a broken Makefile >Fix: Apply the following patch in math/sdpara --- patch-Makefile begins here --- --- Makefile.orig Tue Nov 16 12:41:05 2004 +++ Makefile Tue Nov 16 12:41:36 2004 @@ -33,6 +33,8 @@ LAPACK= -lalapack CBLAS= -lcblas -lf77blas -latlas -lg2c +.include<bsd.port.pre.mk> + .if defined(WITH_OPTIMIZED_FLAGS) FFLAGS+= -O3 -ffast-math -finline-functions -fomit-frame-pointer -funroll-loops -fexpensive-optimizations -malign-double CXXFLAGS+= -O3 -ffast-math -finline-functions -fomit-frame-pointer -funroll-loops -fexpensive-optimizations -malign-double -Wno-multichar @@ -72,4 +74,4 @@ .endif -.include <bsd.port.mk> +.include <bsd.port.post.mk> --- patch-Makefile ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411161948.iAGJmpQT012684>