From owner-freebsd-ports@FreeBSD.ORG Sat Oct 23 00:11:07 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E579716A4CE for ; Sat, 23 Oct 2004 00:11:07 +0000 (GMT) Received: from imf24aec.mail.bellsouth.net (imf24aec.mail.bellsouth.net [205.152.59.72]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4340F43D1D for ; Sat, 23 Oct 2004 00:11:07 +0000 (GMT) (envelope-from ahze@ahze.net) Received: from [192.168.1.5] ([68.209.163.3]) by imf24aec.mail.bellsouth.netESMTP <20041023001106.FIHB22603.imf24aec.mail.bellsouth.net@[192.168.1.5]>; Fri, 22 Oct 2004 20:11:06 -0400 In-Reply-To: <1098488823.37356.6.camel@server.mcneil.com> References: <1098487905.5676.3.camel@server.mcneil.com> <1098488823.37356.6.camel@server.mcneil.com> Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <086661E8-2488-11D9-952F-000A958C81C6@ahze.net> Content-Transfer-Encoding: 7bit From: Michael Johnson Date: Fri, 22 Oct 2004 20:11:05 -0400 To: Sean McNeil X-Mailer: Apple Mail (2.619) cc: amistry@am-productions.biz cc: freebsd-ports@freebsd.org Subject: Re: Bogus patch (was Re: avidemux2 fails to compile) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 00:11:08 -0000 Hi Sean! Thanks for pointing that out, I didn't even realize that was in there that patch is only used to remove windows only functions. I just submitted a patch with a fix. Cheers, Michael On Oct 22, 2004, at 7:47 PM, Sean McNeil wrote: > There appears to be a bogus patch in the ports collection for > audio/faac. Removing files/patch-gcc allows me to compile faac and > avidemux2 without problems. > > The patch is removing a prototype of an exported routine and eliminates > several pragmas. I do not know why the pragmas are removed as they > were > there for a reason plus any compiler that doesn't support them should > just ignore it. I additionally do not know why the prototype for > faacEncEncode is removed. It is required as the following information > demonstrates: > > On Fri, 2004-10-22 at 16:31, Sean McNeil wrote: >> With standard gnome2 and stuff installed under an amd64 I cannot >> compile >> avidemux2. The problem is that faac is installed and it does not have >> any prototype for faacEncEncode. >> >> if c++ -DHAVE_CONFIG_H -I. -I. -I../.. -DXTHREADS -DXUSE_MTSAFE_API >> -I/usr/local/include/atk-1.0 -I/usr/local/include/glib-2.0 >> -I/usr/local/lib/glib-2.0/include -I/usr/X11R6/include/gtk-2.0 >> -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include >> -I/usr/X11R6/include/pango-1.0 -I/usr/local/include/freetype2 >> -I/usr/local/include -DTOOLAME='"''"' -DEXLAME='"''"' >> -I/usr/local/include -I/usr/X11R6/include >> -I/usr/local/include/ffmpeg -I/usr/local/include/a52dec -I.. >> -IADM_library -I../ADM_library -D_LARGEFILE_SOURCE >> -D_FILE_OFFSET_BITS=64 -falign-loops=16 -MT audioeng_faac.o -MD -MP >> -MF ".deps/audioeng_faac.Tpo" -c -o audioeng_faac.o >> audioeng_faac.cpp; \ >> then mv -f ".deps/audioeng_faac.Tpo" ".deps/audioeng_faac.Po"; else >> rm -f ".deps/audioeng_faac.Tpo"; exit 1; fi >> audioeng_faac.cpp: In member function `virtual uint8_t >> AVDMProcessAudio_Faac::getPacket(uint8_t*, uint32_t*, uint32_t*)': >> audioeng_faac.cpp:166: error: `faacEncEncode' undeclared (first use >> this function) >> audioeng_faac.cpp:166: error: (Each undeclared identifier is reported >> only once for each function it appears in.) >> gmake[3]: *** [audioeng_faac.o] Error 1 >> gmake[3]: Leaving directory >> `/usr/ports/multimedia/avidemux2/work/avidemux-2.0.32/avidemux/ >> ADM_audiofilter' >> >> Cheers, >> Sean >>