From owner-svn-src-head@freebsd.org Thu Feb 14 20:48:39 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BD3514E1218 for ; Thu, 14 Feb 2019 20:48:39 +0000 (UTC) (envelope-from juli@northcloak.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D46488B356 for ; Thu, 14 Feb 2019 20:48:38 +0000 (UTC) (envelope-from juli@northcloak.com) Received: by mail-qk1-x731.google.com with SMTP id r21so4428176qkl.11 for ; Thu, 14 Feb 2019 12:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=northcloak-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z3yFFCL2bzat69pupRRj35uxuSKPpPsY7KSM/gIQoKM=; b=EO9j5cbW4GoXG5DC9jocSsZHAJ3bVy77mRSBcu80bQIyFpVvsO1Ljv4SUXkkkt+Zpa gZMCeJR7vc4kUzrou87Nzw2+6DMX87VKgosC2VfQZySPqzCVaDmo3kZRYFym3+ORVhBv eCIEvKWgj9r/j0PvBjfiiUO25BpWNS5UnDye9Bk3cvFy1ypvxg06kSbX3rxmTjHM82BS nBsV7MLk7+fXQO4rqTxh44VoUPvmsC63cmDBDUEES1Nq48xyN99QnSqQxf/M21OC01uz 5TOl2FBnte03LCehWvIxb4+i7G/wQxD7SvoIWQX8OGyerwKHqhGNzF57zYGlYfYQ/dX/ tzIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z3yFFCL2bzat69pupRRj35uxuSKPpPsY7KSM/gIQoKM=; b=N1YLba29DjibxgchCwKg3MpTLcKnU5+OObGxQuxowRYdQcdmKIwLOSH3RqzCjxu1Fr CtuHadlCNT/jTUFPSN1Ojl+erN7MWk5qZ1Oj2J98dThRy6vKYeXCnMUSijLTYnwHk9Fi GiNZA6wlcD09jTo+/F1Cx98DszfWDfQo0InnCU7LQk0Pk6Uj8luAbFzl7rcBEufFKFoY BO3yf5HvkQMVDNRMlTLe/J6i6Ef0BDEMdGZCZ2EXH/2k00gX4rxNzRpcrbo61phxOjCw LpEohx46AZPtbf7Z++D7ohMxUw6UMn21nxgvebqwrNqBYjWan71LO2SL3IwjKzZyz+97 uRkg== X-Gm-Message-State: AHQUAuYROTVeC7nMRbrCv9c8pladsJ0tsMtZRO8C8jzmny1JBJpqwBb+ EIhFJTFpKJRf+yGryoqZs5/WqIKkLACaaFYVLcsufQ== X-Google-Smtp-Source: AHgI3IaMwbqtsgGcNtDIDBSH+bK6wbIe+QNdnACoxeCG6ZHsnbg7tcoM5NPMQZEu+/N8wEgoMFWlP3TGVrG8y1yQREo= X-Received: by 2002:a37:59c4:: with SMTP id n187mr4564233qkb.156.1550177318323; Thu, 14 Feb 2019 12:48:38 -0800 (PST) MIME-Version: 1.0 References: <20190214191329.GB50900@raichu> <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> From: Juli Mallett Date: Thu, 14 Feb 2019 12:48:02 -0800 Message-ID: Subject: Re: svn commit: r344129 - head To: rgrimes@freebsd.org Cc: Mark Johnston , Warner Losh , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: D46488B356 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 20:48:39 -0000 On Thu, 14 Feb 2019 at 12:42, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: > > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < > > > > > Differential Review: https://reviews.freebsd.org/D19193 > > > > > > > > You sited a differential, but not give any attribution > > > > to the external source :-( > > > > > > > > > > The differential review has that information. > > > > External contributors should be recognized by having their names appear > > in the commit logs. > > We even bother to put a special line in the commit template > for this. Further it has been standard operating procedure > for at least as long as I have been back that submitters > are infact recognized in commit messages. > Yeah, Phabricator must not become a second source of truth for who actually did the work, which we had at least one case of recently. That's no good. In this case, the difference between a patch and a bug report is indistinguishable ("word X is misspelt at offset Y in file Z" is probably not really Phabricator fodder at the scale of a single instance), but it should plainly either be a Reported byline if not a Submitted one in the commit message itself. Juli.