Date: Sun, 27 Sep 2009 23:11:56 +0200 From: Max Laier <max@love2party.net> To: "Simon L. Nielsen" <simon@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, src-committers@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org>, svn-src-all@freebsd.org, Thomas Backman <serenity@exscape.org>, svn-src-head@freebsd.org, Dag-Erling Sm??rgrav <des@des.no> Subject: Re: svn commit: r197498 - head/cddl/contrib/opensolaris/cmd/zfs Message-ID: <200909272311.56602.max@love2party.net> In-Reply-To: <20090927145509.GG1495@arthur.nitro.dk> References: <200909251824.n8PIOLte036513@svn.freebsd.org> <20090927070220.GA18022@FreeBSD.org> <20090927145509.GG1495@arthur.nitro.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 27 September 2009 16:55:10 Simon L. Nielsen wrote: > On 2009.09.27 07:02:21 +0000, Alexey Dokuchaev wrote: > > On Sat, Sep 26, 2009 at 10:51:58PM +0200, Dag-Erling Sm??rgrav wrote: > > > Pawel Jakub Dawidek <pjd@FreeBSD.org> writes: > > > > I didn't, thanks. Unfortunately svn doesn't even allow forced > > > > commits, which is a paintful regression compared to cvs. > > > > > > Subversion does allow editing a log message after the fact, but our > > > commit scripts prohibit it. This should IMHO be allowed, and cause a > > > new email to be sent out to note the change. > > > > I recall that one of the reasons behind prohibition was to avoid issues > > with CVS exporter. > > I doubt the CVS exporter would have a problem, though I'm not 100% > sure. I think the problem is more that svnsync does not pick up the > change, but des knows more about that than I do. > > PS. I don't personally have a problem allowing people to edit commit > messages, as long as it's "visible" and we knows what the side-effects > are. svn ps fbsd:forced r197498 head/cddl/contrib/opensolaris/cmd/zfs/zfs.8 svn ci -m "Revised commit message" There you go. Forced commit with no problem. Plus we can also record the revision that the forced commit message belongs to. Disclaimer: Don't try this on the main repo before the SVN-meisters have had a look and approve. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909272311.56602.max>