Date: Mon, 9 Jul 2007 15:46:47 -0400 From: "Constantine A. Murenin" <mureninc@gmail.com> To: "Warner Losh" <imp@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb if_rue.c Message-ID: <f34ca13c0707091246m334899b7u81255d15767bbdea@mail.gmail.com> In-Reply-To: <200707091658.l69Gw8MG080618@repoman.freebsd.org> References: <200707091658.l69Gw8MG080618@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/07/07, Warner Losh <imp@freebsd.org> wrote: > imp 2007-07-09 16:58:08 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb if_rue.c > Log: > When all the other drivers were converted to scheduling a taskqueue to > do the heavy lifting of the 'mii_tick' function, rue was left behind. > Implement this in a naive way. Reports from the field show this makes > the driver functional with some locking issues, as opposed to an > instant panic. Those will be addressed in a later version of the > driver. > > Approved by: re@ (bmah) > > Revision Changes Path > 1.40 +18 -0 src/sys/dev/usb/if_rue.c I think you forgot to commit a change to src/sys/dev/usb/if_ruereg.h: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: warning: left-hand operand of comma expression has no effect /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: warning: left-hand operand of comma expression has no effect /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c: In function 'rue_detach': /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:710: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c: In function 'rue_tick': /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:931: error: 'struct rue_softc' has no member named 'rue_tick_task' Cheers, Constantine.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f34ca13c0707091246m334899b7u81255d15767bbdea>