From owner-svn-ports-head@freebsd.org Tue Jan 22 20:34:28 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBDFC14AEA34; Tue, 22 Jan 2019 20:34:28 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5EF256EF61; Tue, 22 Jan 2019 20:34:28 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 369391810B; Tue, 22 Jan 2019 20:34:28 +0000 (UTC) From: Jan Beich To: Christoph Moench-Tegeder Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r490910 - in head: Mk Mk/Uses mail/thunderbird www/firefox www/firefox-esr www/firefox-i18n www/firefox/files www/palemoon www/seamonkey References: <201901212303.x0LN3jR3059519@repo.freebsd.org> <20190122100911.GA77378@elch.exwg.net> Date: Tue, 22 Jan 2019 21:34:22 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 5EF256EF61 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.86 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; NEURAL_HAM_SHORT(-0.87)[-0.872,0]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 20:34:28 -0000 Christoph Moench-Tegeder writes: > Excuse my hijacking of this thread... > > firefox 65 fails to build (poudirere, amd64, 12.0) when option WAYLAND > is disabled (that't not the default), first error is: > > : In file included from /wrkdirs/usr/ports/www/firefox/work/.build/gfx/webrender_bindings/Unified_cpp_webrender_bindings0.cpp:20: > : > /wrkdirs/usr/ports/www/firefox/work/firefox-65.0/gfx/webrender_bindings/RenderCompositor.cpp:35:47: > error: use of undeclared identifier 'RenderCompositorEGL'; did you > mean 'RenderCompositorOGL'? > : UniquePtr eglCompositor = RenderCompositorEGL::Create(aWidget); > : ^~~~~~~~~~~~~~~~~~~ > : RenderCompositorOGL > > Looking at patch-bug1514156 with perfect hindsight, that's somewhat > obvious as the include of RenderCompositorEGL.h is guarded with an > #ifdef MOZ_WAYLAND (line 20 of RenderCompositor.cpp), but the first use > of RenderCompositorEGL (line 35, see above) is wrapped in an #ifdef > MOZ_WIDGET_GTK. Looking at Try options[1] and automation[2] I'm not sure WAYLAND=off is tested nowadays. In www/firefox WAYLAND=off has no effect[3] unless x11-toolkits/gtk30 also has WAYLAND=off. I've reported the issue upstream[4] but for now just locally remove files/patch-bug1514156. If there's no fix in sight after actual release on 2019-01-29 then the patch can be moved under WAYLAND_EXTRA_PATCHES. [1] https://mozilla-releng.net/trychooser/ [2] https://treeherder.mozilla.org/ [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1501218 [4] https://bugzilla.mozilla.org/show_bug.cgi?id=1514156#c26