Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Nov 2014 10:20:12 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r274395 - projects/sendfile/sys/sys
Message-ID:  <201411121020.12567.jhb@freebsd.org>
In-Reply-To: <201411111939.sABJdbsq068199@svn.freebsd.org>
References:  <201411111939.sABJdbsq068199@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, November 11, 2014 2:39:37 pm Gleb Smirnoff wrote:
> Author: glebius
> Date: Tue Nov 11 19:39:36 2014
> New Revision: 274395
> URL: https://svnweb.freebsd.org/changeset/base/274395
> 
> Log:
>   Undefine SF_NODISKIO and SF_MNOWAIT.
> 
> Modified:
>   projects/sendfile/sys/sys/socket.h
> 
> Modified: projects/sendfile/sys/sys/socket.h
> 
==============================================================================
> --- projects/sendfile/sys/sys/socket.h	Tue Nov 11 19:37:17 2014	
(r274394)
> +++ projects/sendfile/sys/sys/socket.h	Tue Nov 11 19:39:36 2014	
(r274395)
> @@ -600,9 +600,13 @@ struct sf_hdtr_all {
>  
>  /*
>   * Sendfile-specific flag(s)
> + *
> + * SF_NODISKIO and SF_MNOWAIT are unused since 11.0, but we keep
> + * them in header to keep applications compilable.  We will try to
> + * avoid to reuse their bits as long as possible.
>   */
> -#define	SF_NODISKIO     0x00000001
> -#define	SF_MNOWAIT	0x00000002	/* unused since 11.0 */
> +#define	SF_NODISKIO     0x00000000	/* was 0x00000001 */
> +#define	SF_MNOWAIT	0x00000000	/* was 0x00000002 */
>  #define	SF_SYNC		0x00000004
>  #define	SF_KQUEUE	0x00000008
>  #define	SF_NOCACHE	0x00000010

What we've done for mmap() flags is something like:

#define SF_UNUSED0001  0x0000001  /* was SF_NODISKIO */

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201411121020.12567.jhb>