From owner-freebsd-questions Tue Jan 22 1:48:35 2002 Delivered-To: freebsd-questions@freebsd.org Received: from post.mail.nl.demon.net (post-11.mail.nl.demon.net [194.159.73.21]) by hub.freebsd.org (Postfix) with ESMTP id 7918D37B485 for ; Tue, 22 Jan 2002 01:48:18 -0800 (PST) Received: from [212.238.194.207] (helo=tanya.raggedclown.net) by post.mail.nl.demon.net with esmtp (Exim 3.33 #1) id 16SxXN-000Fyj-00 for questions@freebsd.org; Tue, 22 Jan 2002 09:48:17 +0000 Received: by tanya.raggedclown.net (tanya.raggedclown.intra, from userid 500) id 3AC5E1181; Tue, 22 Jan 2002 10:48:16 +0100 (CET) Date: Tue, 22 Jan 2002 10:48:16 +0100 From: Cliff Sarginson To: questions@freebsd.org Subject: Re: What do I do with changes to a kernel module ? Message-ID: <20020122094816.GA2384@raggedclown.net> References: <91790610@toto.iv> <15437.5772.965984.619017@guru.mired.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15437.5772.965984.619017@guru.mired.org> User-Agent: Mutt/1.3.24i Sender: owner-freebsd-questions@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Jan 22, 2002 at 01:36:44AM -0600, Mike Meyer wrote: > Cliff Sarginson types: > > I have put some code into the USB Scanner modules source code to > > add support for Epson 640 USB Scanners. > > What do I do with it now to get it put in the distribution ? > > > > It's in 4.5 RC. > > > > Tough one that, all 6 lines of it :) > > Do a "diff -u" with the sources, and submit a PR with a subject that > starts "[PATCH]". That in the subject line will clue in committers > that you have included a patch to fix the problem, so they don't have > to do anything but test your code and commit it. Oh, yeah - if you > haven't followed style(9), read it and do so before submitting the PR. > > And yes, having become one of Anthony's "few, isolated cases" you get > to call yourself a kernel hacker (jg) now. Me <<-- Proud look. If it gets accepted do I get to learn the secret handshake ? > You don't have to be able > to debug device drivers just by looking at the code. That is a truly > rare talent, as most of us require a working sample device to do that. > Oh I don't have one, I just chose that device at random because I saw there was no support for it :) -- Regards Cliff To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-questions" in the body of the message