Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Sep 2021 03:08:44 GMT
From:      Colin Percival <cperciva@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 34a3091cc3b6 - stable/13 - Turn off acpi_timer_test on !i386 by default
Message-ID:  <202109150308.18F38iGw049171@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by cperciva:

URL: https://cgit.FreeBSD.org/src/commit/?id=34a3091cc3b6e09efe480c7e9e9e72fa9db00d89

commit 34a3091cc3b6e09efe480c7e9e9e72fa9db00d89
Author:     Colin Percival <cperciva@FreeBSD.org>
AuthorDate: 2021-09-15 02:42:14 +0000
Commit:     Colin Percival <cperciva@FreeBSD.org>
CommitDate: 2021-09-15 02:42:14 +0000

    Turn off acpi_timer_test on !i386 by default
    
    The ACPI timer test was introduced in 2002 to detect an erratum in
    chipsets used with Pentium II and Pentium III processors.  No other
    hardware is known to be affected, so on non-i386 systems it should
    be safe to skip the test.
    
    Turning off this test speeds up the FreeBSD boot process by roughly
    140 ms on an EC2 c5.xlarge instance.
    
    The previous behaviour can be restored by setting
    hw.acpi.timer_test_enabled=1
    in /boot/loader.conf.
    
    Requested by:   jhb, imp
    Sponsored by:   https://www.patreon.com/cperciva
---
 sys/dev/acpica/acpi_timer.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sys/dev/acpica/acpi_timer.c b/sys/dev/acpica/acpi_timer.c
index 8be6e0edea7f..e9e488f9022a 100644
--- a/sys/dev/acpica/acpi_timer.c
+++ b/sys/dev/acpica/acpi_timer.c
@@ -79,7 +79,11 @@ static int	acpi_timer_sysctl_freq(SYSCTL_HANDLER_ARGS);
 static void	acpi_timer_boot_test(void);
 
 static int	acpi_timer_test(void);
+#ifdef __i386__
 static int	acpi_timer_test_enabled = 1;
+#else
+static int	acpi_timer_test_enabled = 0;
+#endif
 TUNABLE_INT("hw.acpi.timer_test_enabled", &acpi_timer_test_enabled);
 
 static device_method_t acpi_timer_methods[] = {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109150308.18F38iGw049171>