From owner-svn-ports-all@freebsd.org Mon Dec 31 13:15:03 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94A411433D51; Mon, 31 Dec 2018 13:15:03 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0EB2B6B468; Mon, 31 Dec 2018 13:15:03 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id F293818F22; Mon, 31 Dec 2018 13:15:02 +0000 (UTC) From: Jan Beich To: Rene Ladan Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r488774 - head/graphics/gnash In-Reply-To: (Jan Beich's message of "Mon, 31 Dec 2018 14:11:13 +0100") References: <201812311250.wBVCom6A020495@repo.freebsd.org> Date: Mon, 31 Dec 2018 14:14:57 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 0EB2B6B468 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.90 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_SHORT(-0.92)[-0.917,0]; NEURAL_HAM_LONG(-0.99)[-0.990,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2018 13:15:03 -0000 Jan Beich writes: > Rene Ladan writes: > >> Author: rene >> Date: Mon Dec 31 12:50:48 2018 >> New Revision: 488774 >> URL: https://svnweb.freebsd.org/changeset/ports/488774 >> >> Log: >> graphics/gnash: remove optional dependency on expired KDE4 > [...] >> -OPTIONS_DEFINE= CYGNAL VAAPI DOCS NLS >> -OPTIONS_SINGLE= MEDIA GUI RENDERER >> +OPTIONS_DEFINE= CYGNAL VAAPI DOCS NLS GTK2 >> +OPTIONS_SINGLE= MEDIA RENDERER >> OPTIONS_SINGLE_MEDIA= FFMPEG GSTREAMER >> -OPTIONS_SINGLE_GUI= GTK2 KDE4 > > SINGLE means 1 option must be selected. If KDE4 is gone then GTK2 cannot > be disabled. As DEFINE now allows GTK2 to be disabled it leads to IGNORE. > So, can you drop the cruft as well? [...] Also, don't forget to drop %%GTK2%% in pkg-plist unlike my patch. ;)