From owner-svn-src-head@freebsd.org Fri Sep 30 03:06:37 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9040C02F04; Fri, 30 Sep 2016 03:06:37 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7CD0F11B5; Fri, 30 Sep 2016 03:06:37 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from [136.179.10.143] (helo=[10.140.230.85]) by id.bluezbox.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2 (FreeBSD)) (envelope-from ) id 1bpo9c-000NmF-5y; Thu, 29 Sep 2016 20:06:29 -0700 From: Oleksandr Tymoshenko Message-Id: <96A0937C-C028-4F8F-B209-735F3DBF4338@freebsd.org> Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\)) Subject: Re: svn commit: r306355 - in head/sys: dev/atkbdc sys Date: Thu, 29 Sep 2016 20:05:58 -0700 In-Reply-To: <3815150.rnkVxtqPiv@ralph.baldwin.cx> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: John Baldwin References: <201609262206.u8QM6J5q070986@repo.freebsd.org> <3815150.rnkVxtqPiv@ralph.baldwin.cx> X-Mailer: Apple Mail (2.3226) Sender: gonzo@id.bluezbox.com X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: > On Sep 27, 2016, at 1:55 PM, John Baldwin wrote: > > On Monday, September 26, 2016 10:06:19 PM Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Mon Sep 26 22:06:19 2016 >> New Revision: 306355 >> URL: https://svnweb.freebsd.org/changeset/base/306355 >> >> Log: >> Add Elantech trackpad support >> >> Elantech trackpads are found in some laptops like the Asus UX31E. They >> are "synaptics compatible" but use a slightly different protocol. >> >> Elantech hardware support is not enabled by default and just like >> Synaptic or TrackPoint devices it should be enabled by setting >> tunable, in this case hw.psm.elantech_support, to non-zero value >> >> PR: 205690 >> Submitted by: Vladimir Kondratyev >> MFC after: 1 week >> >> Modified: head/sys/dev/atkbdc/psm.c >> ============================================================================== >> --- head/sys/dev/atkbdc/psm.c Mon Sep 26 20:26:19 2016 (r306354) >> +++ head/sys/dev/atkbdc/psm.c Mon Sep 26 22:06:19 2016 (r306355) >> @@ -389,6 +465, 9 @@ TUNABLE_INT("hw.psm.synaptics_support", >> static int trackpoint_support = 0; >> TUNABLE_INT("hw.psm.trackpoint_support", &trackpoint_support); >> >> +static int elantech_support = 0; >> +TUNABLE_INT("hw.psm.elantech_support", &elantech_support); >> + >> static int verbose = PSM_DEBUG; >> TUNABLE_INT("debug.psm.loglevel", &verbose); > > It would be good to expose all these tunables as CTLFLAG_RDTUN sysctls. Exposing > them that way with a decent description string makes it easier for users to > discover tunables. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 HTML_MESSAGE BODY: HTML included in message Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 03:06:37 -0000 > On Sep 27, 2016, at 1:55 PM, John Baldwin wrote: >=20 > On Monday, September 26, 2016 10:06:19 PM Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Mon Sep 26 22:06:19 2016 >> New Revision: 306355 >> URL: https://svnweb.freebsd.org/changeset/base/306355 >>=20 >> Log: >> Add Elantech trackpad support >>=20 >> Elantech trackpads are found in some laptops like the Asus UX31E. = They >> are "synaptics compatible" but use a slightly different protocol. >>=20 >> Elantech hardware support is not enabled by default and just like >> Synaptic or TrackPoint devices it should be enabled by setting >> tunable, in this case hw.psm.elantech_support, to non-zero value >>=20 >> PR: 205690 >> Submitted by: Vladimir Kondratyev >> MFC after: 1 week >>=20 >> Modified: head/sys/dev/atkbdc/psm.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/dev/atkbdc/psm.c Mon Sep 26 20:26:19 2016 = (r306354) >> +++ head/sys/dev/atkbdc/psm.c Mon Sep 26 22:06:19 2016 = (r306355) >> @@ -389,6 +465,9 @@ TUNABLE_INT("hw.psm.synaptics_support",=20 >> static int trackpoint_support =3D 0; >> TUNABLE_INT("hw.psm.trackpoint_support", &trackpoint_support); >>=20 >> +static int elantech_support =3D 0; >> +TUNABLE_INT("hw.psm.elantech_support", &elantech_support); >> + >> static int verbose =3D PSM_DEBUG; >> TUNABLE_INT("debug.psm.loglevel", &verbose); >=20 > It would be good to expose all these tunables as CTLFLAG_RDTUN = sysctls. Exposing > them that way with a decent description string makes it easier for = users to > discover tunables. Thanks for suggestion, John. Committed in r306474 =E2=80=94=20 gonzo=