From owner-cvs-src@FreeBSD.ORG Thu Sep 4 16:31:43 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0A5A106566C; Thu, 4 Sep 2008 16:31:43 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9D3718FC17; Thu, 4 Sep 2008 16:31:43 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m84GVhGI084025; Thu, 4 Sep 2008 16:31:43 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m84GVhvI084020; Thu, 4 Sep 2008 16:31:43 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200809041631.m84GVhvI084020@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Thu, 4 Sep 2008 16:30:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern tty_compat.c src/sys/sys tty.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Sep 2008 16:31:43 -0000 ed 2008-09-04 16:30:53 UTC FreeBSD src repository Modified files: sys/kern tty_compat.c sys/sys tty.h Log: SVN rev 182763 on 2008-09-04 16:30:53Z by ed Fix an awful bug inside our COMPAT_43TTY code. When I migrated tty_compat.c to MPSAFE TTY, I just hooked it up to the build and fixed it until it compiled and somewhat worked. It turns out this was not the smartest thing, because the old TTY layer also had a field called t_flags, which contained a set of sgtty flags. This means our current COMPAT_43TTY code overwrites the TTY flags, causing all strange problems to occur. Fix this code to use a new struct member called t_compatflags. This commit may cause kern/127054 to be fixed, but this still has to be tested/confirmed by the originator. It has to be fixed anyway. PR: kern/127054 Revision Changes Path 1.41 +14 -12 src/sys/kern/tty_compat.c 1.106 +1 -0 src/sys/sys/tty.h