Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jan 2014 20:19:51 GMT
From:      Hardy Schumacher <hardy.schumacher@gmx.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/185754: [UPDATE] games/0verkill, fix issues reported by portlint 
Message-ID:  <201401132019.s0DKJpqf054764@oldred.freebsd.org>
Resent-Message-ID: <201401132020.s0DKK0ML025536@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         185754
>Category:       ports
>Synopsis:       [UPDATE] games/0verkill, fix issues reported by portlint
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 13 20:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Hardy Schumacher
>Release:        FreeBSD-9.2
>Organization:
>Environment:
FreeBSD gamma.low.org 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255996: Thu Oct  3 20:40:04 CEST 2013     root@gamma.low.org:/usr/obj/usr/src/sys/LOW_GAMMA  i386
>Description:
Portlint reported some issues related to new options framework and direct use of reserved variables.
>How-To-Repeat:
n/a
>Fix:


Patch attached with submission follows:

diff -ruN /usr/ports/games/0verkill/Makefile ./0verkill/Makefile
--- /usr/ports/games/0verkill/Makefile	2013-12-25 14:27:27.000000000 +0100
+++ ./0verkill/Makefile	2014-01-13 21:00:11.000000000 +0100
@@ -31,23 +31,26 @@
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/0verkill ${STAGEDIR}${PREFIX}/bin
-.for file in avi bot editor server test_server
-	${INSTALL_PROGRAM} ${WRKSRC}/${file} \
-		${STAGEDIR}${PREFIX}/bin/0verkill-${file}
+.for filename in avi bot editor server test_server
+	${INSTALL_PROGRAM} ${WRKSRC}/${filename} \
+		${STAGEDIR}${PREFIX}/bin/0verkill-${filename}
 .endfor
 .if ${PORT_OPTIONS:MX11}
 	${INSTALL_PROGRAM} ${WRKSRC}/x0verkill ${STAGEDIR}${PREFIX}/bin
-.for file in avi editor
-	${INSTALL_PROGRAM} ${WRKSRC}/x${file} \
-		${STAGEDIR}${PREFIX}/bin/x0verkill-${file}
+.for filename in avi editor
+	${INSTALL_PROGRAM} ${WRKSRC}/x${filename} \
+		${STAGEDIR}${PREFIX}/bin/x0verkill-${filename}
 .endfor
 .endif
 .for dir in data grx
 	cd ${WRKSRC} && ${COPYTREE_SHARE} ${dir} ${STAGEDIR}${DATADIR}
 .endfor
+
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
-.for file in AUTHORS README.html avi.txt bot.txt doc.html
-	${INSTALL_DATA} ${WRKSRC}/doc/${file} ${STAGEDIR}${DOCSDIR}
+.for filename in AUTHORS README.html avi.txt bot.txt doc.html
+	${INSTALL_DATA} ${WRKSRC}/doc/${filename} ${STAGEDIR}${DOCSDIR}
 .endfor
+.endif
 
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401132019.s0DKJpqf054764>