From owner-cvs-src@FreeBSD.ORG Sun Apr 15 12:13:20 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 379FD16A40B; Sun, 15 Apr 2007 12:13:20 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-6.cisco.com (sj-iport-6.cisco.com [171.71.176.117]) by mx1.freebsd.org (Postfix) with ESMTP id 0D6AF13C44B; Sun, 15 Apr 2007 12:13:19 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-1.cisco.com ([171.71.179.21]) by sj-iport-6.cisco.com with ESMTP; 15 Apr 2007 04:44:49 -0700 X-IronPort-AV: i="4.14,412,1170662400"; d="scan'208"; a="136102196:sNHT46212804" Received: from sj-core-2.cisco.com (sj-core-2.cisco.com [171.71.177.254]) by sj-dkim-1.cisco.com (8.12.11/8.12.11) with ESMTP id l3FBinPC006510; Sun, 15 Apr 2007 04:44:49 -0700 Received: from xbh-sjc-211.amer.cisco.com (xbh-sjc-211.cisco.com [171.70.151.144]) by sj-core-2.cisco.com (8.12.10/8.12.6) with ESMTP id l3FBinZT008250; Sun, 15 Apr 2007 11:44:49 GMT Received: from xfe-sjc-211.amer.cisco.com ([171.70.151.174]) by xbh-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 15 Apr 2007 04:44:49 -0700 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 15 Apr 2007 04:44:48 -0700 Message-ID: <462210D3.8040000@cisco.com> Date: Sun, 15 Apr 2007 07:47:31 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 FreeBSD/i386 SeaMonkey/1.0.6 MIME-Version: 1.0 To: Max Laier References: <200704141827.l3EIRYJM049804@repoman.freebsd.org> <200704142031.02804.max@love2party.net> In-Reply-To: <200704142031.02804.max@love2party.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 15 Apr 2007 11:44:48.0641 (UTC) FILETIME=[78A48710:01C77F53] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=1114; t=1176637489; x=1177501489; c=relaxed/simple; s=sjdkim1004; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20cvs=20commit=3A=20src/sys/netinet=20sctp_indata.c |Sender:=20; bh=jGDt99VeiQSiAqI82B3BJmhfHYgcAgtWp2HvmCajl5A=; b=glB1WV3GJnx/IoSprP/4FQri5vq+zunzU7cCiFYTmpTsxWPDr4qSseVkBMvgSpfpFCt3Zd+k gwRb2JZV5nDkw+7Ftz7TKrMODMSlo0uZWZRubHXSf7QzIQ0imn0a2k1G4aE+Fff1swfbvO1HH+ hbN+sFXK/9f02vW9L2YnZ19Oo=; Authentication-Results: sj-dkim-1; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim1004 verified; ); Cc: rrs@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet sctp_indata.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Apr 2007 12:13:20 -0000 Max Laier wrote: > On Saturday 14 April 2007 20:27, Max Laier wrote: >> mlaier 2007-04-14 18:27:34 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet sctp_indata.c >> Log: >> Fix a typeo - unbreak the build. > > While checking this, I came across the fact that SCTP_SACK_LOGGING depends > on SCTP_STATS_LOGGING. Not sure if that's intended, but it's fixable > with a bit of shuffling in sctputil.c/h > >> Revision Changes Path >> 1.16 +1 -1 src/sys/netinet/sctp_indata.c > Hmm.. well all of the logging is dependant on this. In order to do any logging one must enable SCTP_STATS_LOGGING.. this gets all the allocations and stuff in place. Hmm.. one thing we could do is make it so if you enable any of the loggings STATS_LOGGING gets enabled. Thanks for fixing the typo :-0 I have been offline with the storm for a bit (and a honey do list yesterday) :-0 Hmm let me go add the logging ifdefs to sctputil.h R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)