From owner-p4-projects@FreeBSD.ORG  Wed Apr  9 10:59:21 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6961A37B404; Wed,  9 Apr 2003 10:59:21 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 03F9037B401; Wed,  9 Apr 2003 10:59:21 -0700 (PDT)
Received: from canning.wemm.org (canning.wemm.org [192.203.228.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 954D543F93; Wed,  9 Apr 2003 10:59:20 -0700 (PDT)
	(envelope-from peter@wemm.org)
Received: from wemm.org (localhost [127.0.0.1])
	by canning.wemm.org (Postfix) with ESMTP
	id 7D5A32A8A8; Wed,  9 Apr 2003 10:59:20 -0700 (PDT)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <XFMail.20030407162026.jhb@FreeBSD.org> 
Date: Wed, 09 Apr 2003 10:59:20 -0700
From: Peter Wemm <peter@wemm.org>
Message-Id: <20030409175920.7D5A32A8A8@canning.wemm.org>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 28149 for review 
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Apr 2003 17:59:22 -0000

John Baldwin wrote:
> 
> On 05-Apr-2003 Peter Wemm wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=28149
> > 
> > Change 28149 by peter@peter_overcee on 2003/04/04 19:32:58
> > 
> >       oops. s/l/q/ in write_rflags()
> > 
> > Affected files ...
> > 
> > .. //depot/projects/hammer/sys/x86_64/include/cpufunc.h#7 edit
> > 
> > Differences ...
> > 
> > ==== //depot/projects/hammer/sys/x86_64/include/cpufunc.h#7 (text+ko) ====
> > 
> > @@ -357,7 +357,7 @@
> >  static __inline void
> >  write_rflags(u_long ef)
> 
> On an unrelated topic:
> 
> A lot of these cpufunc things should use register_t rather than int
> or long.  This would have slightly simplified porting them to hammer
> and reduce the diffs.

Yes, I agree.  I intended to backport many of these things.  However,
a caveat.. Some of these entities are actually only 32 bits long, eg: the
cpuid stuff and some of the crX registers.. although you can read/write them
with a 64 bit register, they only have 32 valid bits.  I'll keep the
register_t in mind, I note that the critical* stuff uses it.

Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5