From owner-trustedbsd-cvs@FreeBSD.ORG Wed Aug 30 20:39:03 2006 Return-Path: X-Original-To: trustedbsd-cvs@freebsd.org Delivered-To: trustedbsd-cvs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D32B16A4DA for ; Wed, 30 Aug 2006 20:39:03 +0000 (UTC) (envelope-from owner-perforce@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21B1143D5E for ; Wed, 30 Aug 2006 20:38:58 +0000 (GMT) (envelope-from owner-perforce@freebsd.org) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by cyrus.watson.org (Postfix) with ESMTP id 3F21D46CDD for ; Wed, 30 Aug 2006 16:38:56 -0400 (EDT) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id BD861D1253; Wed, 30 Aug 2006 20:34:57 +0000 (GMT) (envelope-from owner-perforce@freebsd.org) Received: by hub.freebsd.org (Postfix, from userid 32767) id 65E0016A532; Wed, 30 Aug 2006 20:34:53 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 291F416A4E9 for ; Wed, 30 Aug 2006 20:34:53 +0000 (UTC) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E83F843D46 for ; Wed, 30 Aug 2006 20:34:52 +0000 (GMT) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7UKYqtN023263 for ; Wed, 30 Aug 2006 20:34:52 GMT (envelope-from millert@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7UKYqEp023256 for perforce@freebsd.org; Wed, 30 Aug 2006 20:34:52 GMT (envelope-from millert@freebsd.org) Date: Wed, 30 Aug 2006 20:34:52 GMT Message-Id: <200608302034.k7UKYqEp023256@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to millert@freebsd.org using -f From: Todd Miller To: Perforce Change Reviews Cc: Subject: PERFORCE change 105355 for review X-BeenThere: trustedbsd-cvs@FreeBSD.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: TrustedBSD CVS and Perforce commit message list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2006 20:39:03 -0000 http://perforce.freebsd.org/chv.cgi?CH=105355 Change 105355 by millert@millert_g4tower on 2006/08/30 20:34:51 Remove bogus comment (was true of FreeBSD) and fix a style nit. Affected files ... .. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/security/mac_base.c#4 edit Differences ... ==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/security/mac_base.c#4 (text+ko) ==== @@ -1068,15 +1068,11 @@ } newcred = kauth_cred_setlabel(oldcred, intlabel); - mac_update_task_from_cred (newcred, p->task); + mac_update_task_from_cred(newcred, p->task); PROC_LOCK(p); p->p_ucred = newcred; PROC_UNLOCK(p); - /* - * Grab additional reference for use while revoking mmaps, prior - * to releasing the proc lock and sharing the cred. - */ kauth_cred_rele(oldcred); #if 0