From owner-freebsd-net@freebsd.org Tue Aug 14 04:56:26 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05B29106B66D for ; Tue, 14 Aug 2018 04:56:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 983A37E383 for ; Tue, 14 Aug 2018 04:56:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5D357106B66C; Tue, 14 Aug 2018 04:56:25 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BF69106B66B for ; Tue, 14 Aug 2018 04:56:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E08C27E37F for ; Tue, 14 Aug 2018 04:56:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 2032B13D1A for ; Tue, 14 Aug 2018 04:56:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w7E4uOjf048076 for ; Tue, 14 Aug 2018 04:56:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w7E4uNd0048075 for net@FreeBSD.org; Tue, 14 Aug 2018 04:56:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 221137] FreeBSD 11+ does not send ICMP redirects Date: Tue, 14 Aug 2018 04:56:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckay@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 04:56:26 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221137 Stephen McKay changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mckay@FreeBSD.org --- Comment #8 from Stephen McKay --- Created attachment 196187 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D196187&action= =3Dedit Plausible icmp redirect fix for ipv4 and ipv6 I'm surprised that this bug is still unfixed after a year and quite surpris= ed that it is marked "Affects Only Me". ICMP redirects are still in all the R= FCs and are not deprecated, so FreeBSD's recent inability to generate them affe= cts everyone who wishes to be RFC compliant. I have attached a plausible minimalist fix. When net.inet.ip.redirect is s= et (net.inet6.ip6.redirect for ipv6) fast path forwarding (which lacks redirect generation ability) is not attempted. This means the standard code is used= and ICMP redirects are generated. Anyone wishing to have fast path forwarding at the cost of never generating ICMP redirects can disable redirects using sysctl. This might be considered a strong position to take, but the alternative (ignoring an obvious bug) seems to me to be a stronger position with no up side. I think this issue should be resolved before 12 ships. Please let your thoughts be known. --=20 You are receiving this mail because: You are the assignee for the bug.=