Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 02 Nov 2010 17:29:49 +0200
From:      Andriy Gapon <avg@freebsd.org>
To:        Hans Petter Selasky <hselasky@c2i.net>
Cc:        freebsd-acpi@freebsd.org, Lin Ming <ming.m.lin@intel.com>, "Moore, Robert" <robert.moore@intel.com>
Subject:   Re: MacBookPro 5,1
Message-ID:  <4CD02E6D.1070106@freebsd.org>
In-Reply-To: <4CCA60C9.7040600@icyb.net.ua>
References:  <201010121209.06397.hselasky@c2i.net>	 <1288278300.2459.19.camel@localhost> <1288279472.2459.22.camel@localhost>	 <201010281810.23668.hselasky@c2i.net> <1288312476.13315.15.camel@minggr.sh.intel.com> <4CCA594C.7050806@icyb.net.ua> <4CCA5A3B.9000101@icyb.net.ua> <4CCA60C9.7040600@icyb.net.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
on 29/10/2010 08:51 Andriy Gapon said the following:
> I guess that a general problem here is that it is incorrect to merely use
> memcpy/bcopy to create a copy of a resource if the resource has
> ACPI_RESOURCE_SOURCE field in it.

Hans,

could you please test the following patch?

diff --git a/sys/dev/acpica/acpi_pci_link.c b/sys/dev/acpica/acpi_pci_link.c
index dcf101d..e842635 100644
--- a/sys/dev/acpica/acpi_pci_link.c
+++ b/sys/dev/acpica/acpi_pci_link.c
@@ -767,6 +767,8 @@ acpi_pci_link_srs_from_crs
 				    link->l_irq;
 			else
 				resptr->Data.ExtendedIrq.Interrupts[0] = 0;
+			memset(&resptr->Data.ExtendedIrq.ResourceSource, 0,
+			    sizeof(ACPI_RESOURCE_SOURCE));
 			link++;
 			i++;
 			break;


-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CD02E6D.1070106>