Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Nov 2004 12:54:04 -0700
From:      "Jie Gao" <gaoj@cpsc.ucalgary.ca>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/74013: science/psi3 has a broken Makefile when WITH_OPTIMIZED_FLAGS is defined
Message-ID:  <200411161954.iAGJs4QT012859@imgw1.cpsc.ucalgary.ca>
Resent-Message-ID: <200411162000.iAGK0s9p058246@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         74013
>Category:       ports
>Synopsis:       science/psi3 has a broken Makefile when WITH_OPTIMIZED_FLAGS is defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 16 20:00:53 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Jie Gao
>Release:        FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD aibsd 5.3-STABLE FreeBSD 5.3-STABLE #1: Tue Nov 9 12:08:20 MST 2004 gaoj@aibsd:/usr/obj/usr/src/sys/AIBSD i386


	
>Description:
	
science/psi3 has a broken Makefile when WITH_OPTIMIZED_FLAGS is defined. The
problem is in a if branch. So when WITH_OPTIMIZED_FLAGS is not defined, a user
cannot observe the error. But once WITH_OPTIMIZED_FLAGS is defined, the error
is exposed.

>How-To-Repeat:
	
cd /usr/ports/science/psi3
make -DWITH_OPTIMIZED_FLAGS

You will get error message about a broken Makefile

>Fix:

	

Apply the following patch in science/psi3

--- patch-Makefile begins here ---
--- Makefile.orig	Tue Nov 16 12:50:28 2004
+++ Makefile	Tue Nov 16 12:51:09 2004
@@ -39,6 +39,8 @@
 		--with-libdirs="-L${LOCALBASE}/lib" \
 		--with-libs="-lcompat"
 
+.include <bsd.port.pre.mk>
+
 .if defined(WITH_OPTIMIZED_FLAGS)
 FFLAGS+=	-O3 -ffast-math -finline-functions -fomit-frame-pointer -funroll-loops -fexpensive-optimizations -malign-double
 CFLAGS+=	-O3 -ffast-math -finline-functions -fomit-frame-pointer -funroll-loops -fexpensive-optimizations -malign-double
@@ -85,4 +87,4 @@
 	@${MKDIR} ${PREFIX}/share/examples/psi3
 	@${TAR} cf - -C ${WRKSRC}/tests .       | ${TAR} xf - -C ${PREFIX}/share/examples/psi3
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- patch-Makefile ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411161954.iAGJs4QT012859>