Date: Thu, 14 Feb 2019 14:00:48 -0700 From: Warner Losh <imp@bsdimp.com> To: Juli Mallett <juli@northcloak.com> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Mark Johnston <markj@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344129 - head Message-ID: <CANCZdfrTDcQFbR8JAZ7sjti1QbNuRg_DWZ_4xKA25p7Bu2Vm9g@mail.gmail.com> In-Reply-To: <CAGSiXYyjSG7Hq-2mWXyc5qWwpNm1FMVhT8XwF5EEhSPnCw_G%2Bg@mail.gmail.com> References: <20190214191329.GB50900@raichu> <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> <CAGSiXYyjSG7Hq-2mWXyc5qWwpNm1FMVhT8XwF5EEhSPnCw_G%2Bg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 14, 2019, 1:48 PM Juli Mallett <juli@northcloak.com wrote: > On Thu, 14 Feb 2019 at 12:42, Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > >> > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: >> > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < >> > > > > Differential Review: https://reviews.freebsd.org/D19193 >> > > > >> > > > You sited a differential, but not give any attribution >> > > > to the external source :-( >> > > > >> > > >> > > The differential review has that information. >> > >> > External contributors should be recognized by having their names appear >> > in the commit logs. >> >> We even bother to put a special line in the commit template >> for this. Further it has been standard operating procedure >> for at least as long as I have been back that submitters >> are infact recognized in commit messages. >> > > Yeah, Phabricator must not become a second source of truth for who > actually did the work, which we had at least one case of recently. That's > no good. In this case, the difference between a patch and a bug report is > indistinguishable ("word X is misspelt at offset Y in file Z" is probably > not really Phabricator fodder at the scale of a single instance), but it > should plainly either be a Reported byline if not a Submitted one in the > commit message itself. > This is the most pointless waste of time of the year. It was a one letter typo. Yes, maybe I should have included the submitter's name, but I didn't. It doesn't deserve a long thread and a snarky response. Geeze people, get some perspective. Warner >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrTDcQFbR8JAZ7sjti1QbNuRg_DWZ_4xKA25p7Bu2Vm9g>