Date: Wed, 8 Aug 2001 17:43:34 +0300 From: Peter Pentchev <roam@ringlet.net> To: Mark Peek <mark@whistle.com> Cc: Bruce Evans <bde@zeta.org.au>, audit@FreeBSD.ORG Subject: Re: [PATCH] fix a file(1) minor POLA stretching Message-ID: <20010808174334.K534@ringworld.oblivion.bg> In-Reply-To: <p0510031fb796f6fd7184@[207.76.207.129]>; from mark@whistle.com on Wed, Aug 08, 2001 at 07:30:55AM -0700 References: <p0510030bb795ce34d864@[207.76.207.129]> <20010808183309.M6269-100000@besplex.bde.org> <20010808123139.G534@ringworld.oblivion.bg> <p0510031fb796f6fd7184@[207.76.207.129]>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 08, 2001 at 07:30:55AM -0700, Mark Peek wrote:
> At 12:31 PM +0300 8/8/01, Peter Pentchev wrote:
[snip]
> > beforeinstall:
> > $(INSTALL) $(COPY) -o $(BINOWN) -g $(BINGRP) -m $(MAGICMODE) \
> > magic $(DESTDIR)$(MAGICFILE)
> >+ cd ${DESTDIR}${MAGICFILE:H} && \
> >+ ${.OBJDIR}/file -C -m ${DESTDIR}${MAGICFILE}
> >
>
> I don't believe the "cd" is necessary and you could get away with:
>
> ./file -C -m ${DESTDIR}${MAGICFILE}
Oh. Of course you're right :)
Trivial patch attached :)
G'luck,
Peter
--
.siht ekil ti gnidaer eb d'uoy ,werbeH ni erew ecnetnes siht fI
Index: src/usr.bin/file/Makefile
===================================================================
RCS file: /home/ncvs/src/usr.bin/file/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- src/usr.bin/file/Makefile 2001/07/30 03:50:04 1.18
+++ src/usr.bin/file/Makefile 2001/08/08 14:43:22
@@ -58,5 +58,6 @@
beforeinstall:
$(INSTALL) $(COPY) -o $(BINOWN) -g $(BINGRP) -m $(MAGICMODE) \
magic $(DESTDIR)$(MAGICFILE)
+ ./file -C -m $(DESTDIR)$(MAGICFILE)
.include <bsd.prog.mk>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010808174334.K534>