Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Sep 2015 02:30:52 -0400
From:      Allan Jude <allanjude@freebsd.org>
To:        Nathan Whitehorn <nwhitehorn@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r287843 - head/usr.sbin/bsdinstall/scripts
Message-ID:  <55F90C9C.1010508@freebsd.org>
In-Reply-To: <55F90851.2030504@freebsd.org>
References:  <201509160332.t8G3WSdw057340@repo.freebsd.org> <55F90851.2030504@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--XFsntvfRuUwIqxVs46DwxPIgJKMEhtavs
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2015-09-16 02:12, Nathan Whitehorn wrote:
> Can we please fix this elsewhere? Like in gpart? As it is, this
> mechanism is super-fragile: it applies only for one of the two ways of
> configuring ZFS systems, and that only when running an interactive
> install. It's somewhat alleviated by the fact that the other cases can
> set up UEFI boot, but still... Putting it here also causes various spam=

> messages when running on non-x86 systems.
>=20
> At the very least, it should be in zfsboot, not the auto script. That
> will clean this up and make the fix apply to scripted installations as
> well.
> -Nathan

It is setup in scripts/auto specifically because it DOES apply to both
modes (zfsboot and partedit). It applies to UFS in partedit as well.

The various spam messages on non-x86 are from the missing kenv? I should
be able to fix that.

>=20
> On 09/15/15 20:32, Allan Jude wrote:
>> Author: allanjude
>> Date: Wed Sep 16 03:32:27 2015
>> New Revision: 287843
>> URL: https://svnweb.freebsd.org/changeset/base/287843
>>
>> Log:
>>    Add a number of models to the bsdinstall GPT hack blacklist
>>       PR:        194359
>>    Approved by:    bapt (mentor)
>>    MFC after:    2 weeks
>>    Sponsored by:    ScaleEngine Inc.
>>    Differential Revision:    https://reviews.freebsd.org/D3525
>>
>> Modified:
>>    head/usr.sbin/bsdinstall/scripts/auto
>>
>> Modified: head/usr.sbin/bsdinstall/scripts/auto
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>>
>> --- head/usr.sbin/bsdinstall/scripts/auto    Wed Sep 16 03:03:19
>> 2015    (r287842)
>> +++ head/usr.sbin/bsdinstall/scripts/auto    Wed Sep 16 03:32:27
>> 2015    (r287843)
>> @@ -201,6 +201,19 @@ if f_interactive; then
>>               ;;
>>           esac
>>           ;;
>> +    "Hewlett-Packard")
>> +        case "$sys_model" in
>> +        "HP ProBook 4330s")
>> +            dialog_workaround "$msg_gpt_active_fix"
>> +            retval=3D$?
>> +            f_dprintf "gpt_active_fix_prompt=3D[%s]" "$retval"
>> +            if [ $retval -eq $DIALOG_OK ]; then
>> +                export ZFSBOOT_PARTITION_SCHEME=3D"GPT + Active"
>> +                export WORKAROUND_GPTACTIVE=3D1
>> +            fi
>> +            ;;
>> +        esac
>> +        ;;
>>       esac
>>       #
>>       # Motherboard Models
>> @@ -208,7 +221,20 @@ if f_interactive; then
>>       case "$sys_mb_maker" in
>>       "Intel Corporation")
>>           case "$sys_mb_product" in
>> -        "DP965LT")
>> +        "DP965LT"|"D510MO")
>> +            dialog_workaround "$msg_gpt_active_fix"
>> +            retval=3D$?
>> +            f_dprintf "gpt_active_fix_prompt=3D[%s]" "$retval"
>> +            if [ $retval -eq $DIALOG_OK ]; then
>> +                export ZFSBOOT_PARTITION_SCHEME=3D"GPT + Active"
>> +                export WORKAROUND_GPTACTIVE=3D1
>> +            fi
>> +            ;;
>> +        esac
>> +        ;;
>> +    "Acer")
>> +        case "$sys_mb_product" in
>> +        "Veriton M6630G")
>>               dialog_workaround "$msg_gpt_active_fix"
>>               retval=3D$?
>>               f_dprintf "gpt_active_fix_prompt=3D[%s]" "$retval"
>>
>=20
>=20


--=20
Allan Jude


--XFsntvfRuUwIqxVs46DwxPIgJKMEhtavs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQIcBAEBAgAGBQJV+QyfAAoJEBmVNT4SmAt+btcQAI0kgaIzQef47uKM5TlvaxRk
98pDXMitdig6EIwJdKBR/+4x7VYItZBHLr7MFXtlLrmA5UWVyAopui6BuDkZyIoP
s5RUh73SJtrP3IhjIhwLQ72tK7xnjclTE1Jt8GHxNF18v/smsRtumSkD6RPNJ7wC
RYCuEKWt+IpsX7ScSx2LCITyzSH0eHDcB3ZZadCZLWX8is0J3SY5977Gg+o0V9OE
qAggL73HMtB5GNG9Cf/Kdich13tt4Sitl6R0pv24fq3cjLd4JIAuV4gAXIa/eSqA
RE7cgq7ZjJfykt+P8JuW0XIDu+APTojBryuOB0uX+HEG9a9vf6+XPJwQIuM8kdfZ
96SLY8Zs0rzK9ByS6kC6c0XJAnAnRH3+95kzK2pVjvasA6/tW7OHsIfs5dJzFFQB
fOeQ6lAi7J9/AQnrEtPQmLOBa7GUKr1sExCbcagp3xxZgoNdxBOUFWcIIh51s7tf
X2BVtjXRjgMYJdgd3+Y0sTJgQGn/+Yo4sTYPLcz5yfZVppBvQOcAOut5BOGzZtQy
+mK3bFAtp4R4oUaB0Lx/2TaR9ZsIxqLP72deyp2IMpLaMqqdJYJz6BpwvrPqUCgv
0MTbXQgZOLI5rq6oGEcWFCdz2SvC0CS7x3A3niPdvli/Na6zOlKYwOSGTLBDDuJP
yz0m3iI9rnMvDSOm7d4x
=ffEL
-----END PGP SIGNATURE-----

--XFsntvfRuUwIqxVs46DwxPIgJKMEhtavs--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55F90C9C.1010508>