Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Jun 2002 23:26:56 -0700
From:      Brooks Davis <brooks@one-eyed-alien.net>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        Brooks Davis <brooks@one-eyed-alien.net>, "David O'Brien" <obrien@FreeBSD.org>, current@FreeBSD.org, phk@FreeBSD.org
Subject:   Re: dump (via amanda) causing panics
Message-ID:  <20020607232656.B1469@Odin.AC.HMC.Edu>
In-Reply-To: <20020608143938.M18304-100000@gamplex.bde.org>; from bde@zeta.org.au on Sat, Jun 08, 2002 at 02:45:06PM %2B1000
References:  <20020607150716.A19826@Odin.AC.HMC.Edu> <20020608143938.M18304-100000@gamplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--i0/AhcQY5QxfSsSZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 08, 2002 at 02:45:06PM +1000, Bruce Evans wrote:
> On Fri, 7 Jun 2002, Brooks Davis wrote:
>=20
> > On Fri, Jun 07, 2002 at 02:16:45PM -0700, Brooks Davis wrote:
> > > On Fri, Jun 07, 2002 at 01:30:37PM -0700, David O'Brien wrote:
> > > > On Fri, Jun 07, 2002 at 12:59:55PM -0700, Brooks Davis wrote:
> > > > > Applying phk's patch seems to have fixed it.  It's a bit overkill=
 for
> > > > > fixing dump, but it did work and I guess this way I can do some l=
imited
> > > > > testing of the ufs2 patch.
>=20
> Is that the full ufs2 patch?  phk also committed a quick fix for dump.

That's with the full ufs2 patch.

> > Here's a sample of the errors I'm seeing:
> >
> >   DUMP: read error from /dev/ad0s2f: Invalid argument: [sector -1980991=
191]: count=3D-1
> >   DUMP: read error from /dev/ad0s2f: Invalid argument: [sector -1980991=
190]: count=3D-1
> > ...
>=20
> I saw similarly bogus sector (block) numbers when I first debugged this
> problem.  They were caused by missing prototypes.  32-bit block numbers
> were passed to unprototyped functions that expected daddr_t block numbers.
> When daddr_t was changed to 64 bits, there was garbage in the top 32 bits.
>=20
> dump doesn't compile cleanly at a high WARNS level, so now would be a good
> time to WARNSify it.

That sounds like a good idea.  If someone else doesn't get there first,
I'll take a look at that soon.  If nothing else, there's the plane trip
down to SFO for USENIX.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--i0/AhcQY5QxfSsSZ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9AaOvXY6L6fI4GtQRAlexAKC3uTuPS0JcZkhFQE6hCv8B19tLMgCcCp22
G/SVUGxxYDLNruX4syirV5s=
=kbV4
-----END PGP SIGNATURE-----

--i0/AhcQY5QxfSsSZ--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020607232656.B1469>