Date: Thu, 20 Oct 2011 11:35:53 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r226552 - head/sys/boot/zfs Message-ID: <20111020093552.GF1722@garage.freebsd.pl> In-Reply-To: <4E9FCA7D.8010900@FreeBSD.org> References: <201110192340.p9JNebOH047566@svn.freebsd.org> <4E9FCA7D.8010900@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--FoLtEtfbNGMjfgrs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 20, 2011 at 10:15:09AM +0300, Andriy Gapon wrote: > I believe that this commit is incorrect. > It does appear to do the right thing for raidz, but I believe that it bre= aks the > simple case when v_read is vdev_read_phys. Now because the bp argument i= s not > NULL, the latter will try to read BP_GET_PSIZE(bp) bytes instead of > SPA_GANGBLOCKSIZE bytes. >=20 > I believe that my patch that I shared (much) earlier handles this issue > correctly and integrally: > http://article.gmane.org/gmane.os.freebsd.devel.file-systems/13130 > Did you find anything wrong with it? > If not, then maybe we can get back to discussing it? You see. My memory is very short:) and I remembered that you were working on gang blocks in ZFS boot code, but could find the commit, so I went ahead with my changes. Those changes still didn't fix one problem for me. Your patch seems to be much more complete and correct and it fixes all my problems. Please, wait no longer and commit your patch! We have to have this in 9.0. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --FoLtEtfbNGMjfgrs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEUEARECAAYFAk6f63cACgkQForvXbEpPzQhHgCYkR2P9p1KvyM+cAvSVBVvB2/3 cACeM6LnyhsCvH10VZMaCErwwVHetG0= =/zeE -----END PGP SIGNATURE----- --FoLtEtfbNGMjfgrs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111020093552.GF1722>